-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Mm 68768 auto cache rolling cleanup #9958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
carlisgg
wants to merge
19
commits into
main
Choose a base branch
from
MM-68768-cache-rolling-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
36bc8eb
auto cache rolling cleanup for posts
carlisgg f505ecc
ai threads rolling cleanup
carlisgg 999625d
auto rolling cleanup of playbook runs
carlisgg 70769be
fix to import and use renamed module
carlisgg 3c67d20
makes post cleanup atomic by moving processing to sql layer
carlisgg 79cdd32
restore previous file viewer post id and use full error logging
carlisgg 85aa17c
performs vacuum as last step and removes unused code
carlisgg 74d56f2
return early on empty channel array
carlisgg 014acc8
address gallery items without a post id
carlisgg 7d6acfb
prevent drafts to be deleted as part of auto cache cleanups
carlisgg 2a41833
unset channel oldest visible on channel switch
carlisgg 958ad49
clear oldest visible on empty array
carlisgg 3fba595
revert early return to prevent flickering
carlisgg 98b1bc6
restore previous playbookrun id on unmount
carlisgg a694166
fixes issue creating data retention deletion batches
carlisgg a8d2868
move active threads root cleanup protection to SQL execution
carlisgg 94057b9
notify observers of range changes in post lists
carlisgg 4a89661
in flight protection for auto cache cleanup runs
carlisgg 5363b38
add space around operator
carlisgg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,299 @@ | ||
| // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. | ||
| // See LICENSE.txt for license information. | ||
|
|
||
| import {deletePostsInChannelsByCutoff} from '@actions/local/post'; | ||
| import {queryAIThreadsBefore} from '@agents/database/queries/thread'; | ||
| import {Screens} from '@constants'; | ||
| import {MM_TABLES, SYSTEM_IDENTIFIERS} from '@constants/database'; | ||
| import DateConstants from '@constants/datetime'; | ||
| import {AUTO_CACHE_CLEANUP_PROTECTION_BUFFER} from '@constants/post'; | ||
| import DatabaseManager from '@database/manager'; | ||
| import EphemeralModeManager from '@managers/ephemeral_mode_manager'; | ||
| import {queryPlaybookRunsBefore} from '@playbooks/database/queries/run'; | ||
| import { | ||
| createAtOfNthPostOlderThan, | ||
| getPostById, | ||
| } from '@queries/servers/post'; | ||
| import {getCurrentChannelId} from '@queries/servers/system'; | ||
| import EphemeralStore from '@store/ephemeral_store'; | ||
| import {NavigationStore} from '@store/navigation_store'; | ||
| import {getFullErrorMessage} from '@utils/errors'; | ||
| import {logDebug, logError} from '@utils/log'; | ||
|
carlisgg marked this conversation as resolved.
|
||
|
|
||
| import type {Database, Model} from '@nozbe/watermelondb'; | ||
| import type PostInChannelModel from '@typings/database/models/servers/posts_in_channel'; | ||
| import type SystemModel from '@typings/database/models/servers/system'; | ||
|
|
||
| const {SERVER: {POSTS_IN_CHANNEL, SYSTEM}} = MM_TABLES; | ||
|
|
||
| // Guards against overlapping runs when rapid reconnects call this un-awaited. | ||
| const inFlight = new Set<string>(); | ||
|
|
||
| interface CleanupProtections { | ||
| viewedChannelId: string | undefined; | ||
| viewedChannelLimit: number; | ||
| threadParentChannelId: string | undefined; | ||
| threadParentLimit: number; | ||
| viewedThreadId: string | undefined; | ||
| fileViewerPostId: string | undefined; | ||
| viewedPlaybookRunId: string | undefined; | ||
| } | ||
|
|
||
| async function getLastAutoCacheCleanupRun(database: Database): Promise<number> { | ||
| try { | ||
| const data = await database.get<SystemModel>(SYSTEM).find(SYSTEM_IDENTIFIERS.LAST_AUTO_CACHE_CLEANUP_RUN); | ||
| return data?.value ? Number(data.value) : 0; | ||
| } catch { | ||
| return 0; | ||
| } | ||
| } | ||
|
|
||
| async function setLastAutoCacheCleanupRun(serverUrl: string): Promise<void> { | ||
| try { | ||
| const {operator} = DatabaseManager.getServerDatabaseAndOperator(serverUrl); | ||
| await operator.handleSystem({ | ||
| systems: [{id: SYSTEM_IDENTIFIERS.LAST_AUTO_CACHE_CLEANUP_RUN, value: Date.now()}], | ||
| prepareRecordsOnly: false, | ||
| }); | ||
| } catch (error) { | ||
| logError('autoCacheCleanup setLastAutoCacheCleanupRun', getFullErrorMessage(error)); | ||
| } | ||
|
Copilot marked this conversation as resolved.
|
||
| } | ||
|
|
||
| async function computeCleanupProtections( | ||
| database: Database, | ||
| isActive: boolean, | ||
| ): Promise<CleanupProtections> { | ||
| if (!isActive) { | ||
| return { | ||
| viewedChannelId: undefined, | ||
| viewedChannelLimit: Infinity, | ||
| viewedThreadId: undefined, | ||
| threadParentChannelId: undefined, | ||
| threadParentLimit: Infinity, | ||
| fileViewerPostId: undefined, | ||
| viewedPlaybookRunId: undefined, | ||
| }; | ||
| } | ||
|
|
||
| const isChannelScreenMounted = NavigationStore.getScreensInStack().includes(Screens.CHANNEL); | ||
| const viewedChannelId = (isChannelScreenMounted && await getCurrentChannelId(database)) || undefined; | ||
| const oldestVisible = EphemeralStore.getCurrentChannelOldestVisibleCreateAt(); | ||
|
|
||
| let viewedChannelLimit = Infinity; | ||
| if (viewedChannelId && oldestVisible) { | ||
| viewedChannelLimit = | ||
| await createAtOfNthPostOlderThan( | ||
| database, viewedChannelId, oldestVisible, AUTO_CACHE_CLEANUP_PROTECTION_BUFFER, | ||
| ) ?? Infinity; | ||
| } | ||
|
|
||
| const viewedThreadId = EphemeralStore.getCurrentThreadId() || undefined; | ||
| let threadParentChannelId: string | undefined; | ||
| let threadParentLimit = Infinity; | ||
|
|
||
| if (viewedThreadId) { | ||
| const rootPost = await getPostById(database, viewedThreadId); | ||
| if (rootPost) { | ||
| threadParentChannelId = rootPost.channelId; | ||
|
|
||
| // Floored at the root's own create_at so the open thread's replies (always >= root.createAt) | ||
| // are never deleted, even when there aren't enough preceding posts to compute a wider buffer. | ||
|
carlisgg marked this conversation as resolved.
|
||
| threadParentLimit = Math.min( | ||
| rootPost.createAt, | ||
| (await createAtOfNthPostOlderThan( | ||
| database, threadParentChannelId, rootPost.createAt, AUTO_CACHE_CLEANUP_PROTECTION_BUFFER, | ||
| )) ?? Infinity, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| const fileViewerPostId = EphemeralStore.getCurrentFileViewerPostId() || undefined; | ||
| const viewedPlaybookRunId = EphemeralStore.getCurrentPlaybookRunId() || undefined; | ||
|
|
||
| return { | ||
| viewedChannelId, | ||
| viewedChannelLimit, | ||
| viewedThreadId, | ||
| threadParentChannelId, | ||
| threadParentLimit, | ||
| fileViewerPostId, | ||
| viewedPlaybookRunId, | ||
| }; | ||
| } | ||
|
|
||
| function channelProtectionLimit(channelId: string, protections: CleanupProtections): number { | ||
| let limit = Infinity; | ||
| if (channelId === protections.viewedChannelId) { | ||
| limit = Math.min(limit, protections.viewedChannelLimit); | ||
| } | ||
| if (channelId === protections.threadParentChannelId) { | ||
| limit = Math.min(limit, protections.threadParentLimit); | ||
| } | ||
| return limit; | ||
| } | ||
|
|
||
| async function cleanupPosts( | ||
| serverUrl: string, | ||
| database: Database, | ||
| cutoff: number, | ||
| protections: CleanupProtections, | ||
| ): Promise<void> { | ||
| const postsInChannelItems = await database.get<PostInChannelModel>(POSTS_IN_CHANNEL).query().fetch(); | ||
| const channelsWithPostRanges = new Set(postsInChannelItems.map((row) => row.channelId)); | ||
|
|
||
| const unprotectedChannels = new Set( | ||
| postsInChannelItems. | ||
| map((row) => row.channelId). | ||
| filter((channelId) => channelId !== protections.viewedChannelId && channelId !== protections.threadParentChannelId), | ||
| ); | ||
|
|
||
| const excludedPostIds: Set<string> = new Set([ | ||
| ...(protections.viewedThreadId ? [protections.viewedThreadId] : []), | ||
| ...(protections.fileViewerPostId ? [protections.fileViewerPostId] : []), | ||
| ]); | ||
|
|
||
| // delete posts in channels not currently being viewed using a single query. | ||
| // PostsInChannel/MyChannel bookkeeping is applied atomically inside this call. | ||
| if (unprotectedChannels.size > 0) { | ||
| const {error: deleteError} = await deletePostsInChannelsByCutoff(serverUrl, Array.from(unprotectedChannels), cutoff, excludedPostIds); | ||
| if (deleteError) { | ||
| throw deleteError; | ||
| } | ||
| } | ||
|
|
||
| // delete posts in viewed channel if any; reconcile so its mounted post list re-queries | ||
| if (protections.viewedChannelId && channelsWithPostRanges.has(protections.viewedChannelId)) { | ||
| const computedChannelCutoff = Math.min(cutoff, channelProtectionLimit(protections.viewedChannelId, protections)); | ||
| const {error: deleteError} = await deletePostsInChannelsByCutoff(serverUrl, [protections.viewedChannelId], computedChannelCutoff, excludedPostIds, true); | ||
| if (deleteError) { | ||
| throw deleteError; | ||
| } | ||
| } | ||
|
|
||
| // delete posts in thread parent channel if any; reconcile so its mounted post list re-queries | ||
| if (protections.threadParentChannelId && protections.threadParentChannelId !== protections.viewedChannelId && channelsWithPostRanges.has(protections.threadParentChannelId)) { | ||
| const computedChannelCutoff = Math.min(cutoff, channelProtectionLimit(protections.threadParentChannelId, protections)); | ||
| const {error: deleteError} = await deletePostsInChannelsByCutoff(serverUrl, [protections.threadParentChannelId], computedChannelCutoff, excludedPostIds, true); | ||
| if (deleteError) { | ||
| throw deleteError; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // AI threads self-heal on next open (re-fetched from the server), so the only | ||
| // protection is the currently-viewed thread. viewedThreadId is the open thread's | ||
| // root post id, which equals the AiThread id; it is undefined on non-active servers. | ||
| async function cleanupAiThreads( | ||
| database: Database, | ||
| operator: {batchRecords: (models: Model[], description: string) => Promise<void>}, | ||
| cutoff: number, | ||
| viewedThreadId: string | undefined, | ||
| ) { | ||
| const staleThreads = await queryAIThreadsBefore(database, cutoff).fetch(); | ||
| const prepared = staleThreads. | ||
| filter((thread) => thread.id !== viewedThreadId). | ||
| map((thread) => thread.prepareDestroyPermanently()); | ||
|
|
||
| if (prepared.length > 0) { | ||
| await operator.batchRecords(prepared, 'cleanupAiThreads'); | ||
| } | ||
| } | ||
|
|
||
| // Playbook runs re-fetch from the server on next open, so the only protection is | ||
| // the currently-viewed run; viewedPlaybookRunId is undefined on non-active servers. | ||
| async function cleanupPlaybookRuns( | ||
| database: Database, | ||
| operator: {batchRecords: (models: Model[], description: string) => Promise<void>}, | ||
| cutoff: number, | ||
| viewedPlaybookRunId: string | undefined, | ||
| ) { | ||
| const staleRuns = await queryPlaybookRunsBefore(database, cutoff).fetch(); | ||
| const prepared = (await Promise.all( | ||
| staleRuns. | ||
| filter((run) => run.id !== viewedPlaybookRunId). | ||
| map((run) => run.prepareDestroyWithRelations()), | ||
| )).flat(); | ||
|
|
||
| if (prepared.length > 0) { | ||
| await operator.batchRecords(prepared, 'cleanupPlaybookRuns'); | ||
| } | ||
| } | ||
|
|
||
| export async function autoCacheCleanup(serverUrl: string): Promise<void> { | ||
| const cleanupDays = EphemeralModeManager.getAutoCacheCleanupDays(serverUrl); | ||
| if (cleanupDays <= 0) { | ||
| logDebug('autoCacheCleanup: cleanupDays <= 0 for', serverUrl); | ||
| return; | ||
| } | ||
|
carlisgg marked this conversation as resolved.
|
||
|
|
||
| if (inFlight.has(serverUrl)) { | ||
| logDebug('autoCacheCleanup: already running for', serverUrl); | ||
| return; | ||
| } | ||
| inFlight.add(serverUrl); | ||
|
|
||
| try { | ||
| let database: Database; | ||
| let operator: {batchRecords: (models: Model[], description: string) => Promise<void>}; | ||
| try { | ||
| ({database, operator} = DatabaseManager.getServerDatabaseAndOperator(serverUrl)); | ||
| } catch (error) { | ||
| logError('autoCacheCleanup getServerDatabaseAndOperator', getFullErrorMessage(error)); | ||
| return; | ||
| } | ||
|
|
||
| const toDate = (ms: number) => (ms ? new Date(ms).toString() : undefined); | ||
| const lastRunAt = await getLastAutoCacheCleanupRun(database); | ||
| const shouldRun = !lastRunAt || new Date(lastRunAt).toDateString() !== new Date().toDateString(); | ||
| logDebug('autoCacheCleanup: rolling cleanup check for', serverUrl, '— lastRunAt:', toDate(lastRunAt), '— shouldRun:', shouldRun); | ||
| if (!shouldRun) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| const cutoff = Date.now() - (cleanupDays * DateConstants.SECONDS.DAY * 1000); | ||
| const activeUrl = await DatabaseManager.getActiveServerUrl(); | ||
| const isActive = serverUrl === activeUrl; | ||
|
|
||
| const limits = await computeCleanupProtections(database, isActive); | ||
| const toDateOrInf = (ms: number) => { | ||
| if (!Number.isFinite(ms)) { | ||
| return ms > 0 ? 'Infinity' : '-Infinity'; | ||
| } | ||
| return new Date(ms).toString(); | ||
| }; | ||
| logDebug( | ||
| 'autoCacheCleanup: running for', serverUrl, | ||
| '— cutoff:', toDate(cutoff), | ||
| '— isActive:', isActive, | ||
| '— currentChannelId:', limits.viewedChannelId, | ||
| '— viewedChannelLimit:', toDateOrInf(limits.viewedChannelLimit), | ||
| '— threadParentChannelId:', limits.threadParentChannelId, | ||
| '— threadParentLimit:', toDateOrInf(limits.threadParentLimit), | ||
| '— currentThreadId:', limits.viewedThreadId, | ||
| '— fileViewerPostId:', limits.fileViewerPostId, | ||
| '— currentPlaybookRunId:', limits.viewedPlaybookRunId, | ||
| ); | ||
|
|
||
| await cleanupPosts(serverUrl, database, cutoff, limits); | ||
| await cleanupAiThreads(database, operator, cutoff, limits.viewedThreadId); | ||
| await cleanupPlaybookRuns(database, operator, cutoff, limits.viewedPlaybookRunId); | ||
|
|
||
| await setLastAutoCacheCleanupRun(serverUrl); | ||
|
|
||
| try { | ||
| await database.unsafeVacuum(); | ||
| } catch (vacuumError) { | ||
| logError('autoCacheCleanup unsafeVacuum', getFullErrorMessage(vacuumError)); | ||
| } | ||
|
|
||
| logDebug('autoCacheCleanup: completed successfully for', serverUrl); | ||
| } catch (error) { | ||
| logError('autoCacheCleanup', getFullErrorMessage(error)); | ||
| } | ||
| logDebug('autoCacheCleanup: done for', serverUrl); | ||
| } finally { | ||
| inFlight.delete(serverUrl); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.