Skip to content

Update supported ESR version#9954

Open
amyblais wants to merge 5 commits into
mainfrom
update-supported-esr-v11-7-0
Open

Update supported ESR version#9954
amyblais wants to merge 5 commits into
mainfrom
update-supported-esr-v11-7-0

Conversation

@amyblais

@amyblais amyblais commented Jul 20, 2026

Copy link
Copy Markdown
Member

QA Test Steps:

  1. Connect to a server with a version lower than ESR (e.g. v10.10). Expected: Prompt to upgrade the server is received.
  2. Connect to a server with a version equal to ESR (v10.11). Expected: Prompt to upgrade the server is not received.
  3. Connect to a server with a version greater than ESR (e.g. v10.12). Expected: Prompt to upgrade the server is not received.
Updated minimum supported version to v11.7.0.

Generated by Claude Code

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Documentation Impact Analysis — updates needed

Documentation Impact Analysis

Overall Assessment: Documentation Updates Required

Changes Summary

PR #9954 bumps the mobile app's minimum supported Mattermost server version from ESR v10.11.0 to ESR v11.7.0 (and the absolute minimum from v9.11.0 to v10.11.0). This is a breaking compatibility change for administrators running older server versions who upgrade their mobile app, and it must be reflected in the per-release changelog entry when v2.43+ ships.

Documentation Impact Details

Change Type Files Changed Affected Personas Documentation Action Docs Location
New or changed app configuration / feature flag (minimum server version constant) app/constants/supported_server.ts System Administrator Update the upcoming mobile release changelog entry to state "Server v11.7.0+ is required" and include the standard ESR upgrade notice replacing the v10.11.0 reference docs/source/product-overview/mobile-app-changelog.md
User-facing behavioral change (server-version gate prompt) app/constants/supported_server.ts System Administrator Confirm that the compatibility table row for the next planned release (v2.43+) in the mobile releases page already reflects v11.7 as the minimum ESR (rows currently show v11.7 but no explicit "minimum required" callout) docs/source/product-overview/mattermost-mobile-releases.md

Recommended Actions

  • When the next mobile release (v2.43) changelog entry is added to docs/source/product-overview/mobile-app-changelog.md, set "Server Versions Supported" to "Server v11.7.0+ is required" and update the Compatibility note to read: "Upgrade to server version v11.7.0 or later is required. Support for server ESR v10.11.0 has ended and upgrading to server ESR v11.7.0 or later is required." (following the same pattern used for the v10.11 bump in v2.31).
  • Verify docs/source/product-overview/mattermost-mobile-releases.md — the planned release rows for v2.43+ already list v11.7 as the oldest supported ESR, but confirm no row still shows v10.11 as the minimum required version once v2.43 ships.

Confidence

High — The mobile-app-changelog.md follows a strict, repeated pattern of documenting the minimum required server version for every release. The code change directly controls the version gate that triggers the "upgrade your server" alert. The existing docs would be inaccurate for the next release if not updated.

@github-actions github-actions Bot added the Docs/Needed Requires documentation label Jul 20, 2026
@amyblais amyblais added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jul 20, 2026 — with Claude
@amyblais
amyblais requested a review from lieut-data July 20, 2026 08:52
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The supported Mattermost Server version is updated to 11.7.0+, with version constants, published compatibility references, and related test coverage synchronised accordingly. A patch version constant is also exported.

Changes

Server version requirement

Layer / File(s) Summary
Version constants and compatibility metadata
app/constants/supported_server.ts, README.md, fastlane/metadata/android/en-US/full_description.txt, fastlane/metadata/changelog
Updates exported version values to 11.7.0+, adds PATCH_VERSION = 0 to the default export, and synchronises README, Android metadata, and changelog requirements.
Version validation test alignment
app/managers/global_event_handler.test.ts
Uses FULL_VERSION instead of a hardcoded server version when testing the minimum-version path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change: updating the supported ESR version.
Description check ✅ Passed The description is related to the version bump and QA steps in the changeset.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-supported-esr-v11-7-0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/constants/supported_server.ts`:
- Around line 4-7: Update the MIN_REQUIRED_VERSION constant to 11.7.0 so upgrade
prompting matches the minimum major and minor versions represented by
MAJOR_VERSION, MIN_VERSION, and FULL_VERSION. Leave the surrounding version
constants and global_event_handler.ts usage unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 813417f7-23e3-43ee-b711-3ea21061b2cd

📥 Commits

Reviewing files that changed from the base of the PR and between 9a40cad and b584cdb.

📒 Files selected for processing (4)
  • README.md
  • app/constants/supported_server.ts
  • fastlane/metadata/android/en-US/full_description.txt
  • fastlane/metadata/changelog

Comment thread app/constants/supported_server.ts
Derive the "meets minimum requirement" test version from FULL_VERSION
so it doesn't go stale on the next minimum-version bump.
@mattermost-build mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Jul 21, 2026
@amyblais

Copy link
Copy Markdown
Member Author

Added @yasserfaraazkhan as a reviewer as I fixed some failing tests.

@github-actions

Copy link
Copy Markdown

Coverage Comparison Report

Generated on July 21, 2026 at 05:48:39 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     88.08% |     88.08% |     0.00% |
| Statements      |     87.94% |     87.94% |     0.00% |
| Branches        |     76.88% |     76.88% |     0.00% |
| Functions       |     87.34% |     87.34% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     85.06% |     85.06% |     0.00% |
+-----------------+------------+------------+-----------+

@lindalumitchell lindalumitchell added the Build Apps for PR Build the mobile app for iOS and Android to test label Jul 21, 2026
@mattermost-build mattermost-build removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Jul 21, 2026

@lindalumitchell lindalumitchell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyblais @enahum I believe this is not working as expected.

QA Review — ❌ Blocked

Tested on PR build (iOS + Android) against v9.11.18, v10.11.22, v11.6.6, v11.7.0, and v11.8.4.

The upgrade prompt correctly appeared on v9.11.18, confirming the mechanism works. However, it did not appear on v10.11.22 or v11.6.6, where it should — because MIN_REQUIRED_VERSION in app/constants/supported_server.ts was not updated and remains at '10.11.0'. The runtime alert in global_event_handler.ts gates on this constant, not on FULL_VERSION, so the effective enforcement threshold has not changed.

Required fix: MIN_REQUIRED_VERSION = '11.7.0'

No-prompt results on v11.7.0 and v11.8.4 were correct, but are not trustworthy until the above is resolved. Happy to re-test once a new build is available.

Full test plan: https://mattermost.atlassian.net/wiki/x/EAAHHAE

@amyblais

amyblais commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

The fix would be to update MIN_REQUIRED_VERSION to 11.7.0. However, we don't want to do this at this point because we want to keep MIN_REQUIRED_VERSION in the trailing ESR version.

I'd say we keep this PR as-is and accept the QA test results. Unless @enahum you're aware of another solution for the code?

@enahum

enahum commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Anything older than the min verdion should show the alert, I understand that is the case, correct? If it is, then is fine

@amyblais

Copy link
Copy Markdown
Member Author

Anything older than the min verdion should show the alert, I understand that is the case, correct? If it is, then is fine

That's the case 👍 @lindalumitchell Your test results are correct; I'll update the PR description.

@amyblais
amyblais requested a review from lindalumitchell July 22, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Build Apps for PR Build the mobile app for iOS and Android to test Docs/Needed Requires documentation release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants