Update supported ESR version#9954
Conversation
Documentation Impact Analysis — updates neededDocumentation Impact AnalysisOverall Assessment: Documentation Updates Required Changes SummaryPR #9954 bumps the mobile app's minimum supported Mattermost server version from ESR v10.11.0 to ESR v11.7.0 (and the absolute minimum from v9.11.0 to v10.11.0). This is a breaking compatibility change for administrators running older server versions who upgrade their mobile app, and it must be reflected in the per-release changelog entry when v2.43+ ships. Documentation Impact Details
Recommended Actions
ConfidenceHigh — The
|
📝 WalkthroughWalkthroughThe supported Mattermost Server version is updated to 11.7.0+, with version constants, published compatibility references, and related test coverage synchronised accordingly. A patch version constant is also exported. ChangesServer version requirement
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/constants/supported_server.ts`:
- Around line 4-7: Update the MIN_REQUIRED_VERSION constant to 11.7.0 so upgrade
prompting matches the minimum major and minor versions represented by
MAJOR_VERSION, MIN_VERSION, and FULL_VERSION. Leave the surrounding version
constants and global_event_handler.ts usage unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 813417f7-23e3-43ee-b711-3ea21061b2cd
📒 Files selected for processing (4)
README.mdapp/constants/supported_server.tsfastlane/metadata/android/en-US/full_description.txtfastlane/metadata/changelog
Derive the "meets minimum requirement" test version from FULL_VERSION so it doesn't go stale on the next minimum-version bump.
|
Added @yasserfaraazkhan as a reviewer as I fixed some failing tests. |
Coverage Comparison Report |
lindalumitchell
left a comment
There was a problem hiding this comment.
@amyblais @enahum I believe this is not working as expected.
QA Review — ❌ Blocked
Tested on PR build (iOS + Android) against v9.11.18, v10.11.22, v11.6.6, v11.7.0, and v11.8.4.
The upgrade prompt correctly appeared on v9.11.18, confirming the mechanism works. However, it did not appear on v10.11.22 or v11.6.6, where it should — because MIN_REQUIRED_VERSION in app/constants/supported_server.ts was not updated and remains at '10.11.0'. The runtime alert in global_event_handler.ts gates on this constant, not on FULL_VERSION, so the effective enforcement threshold has not changed.
Required fix: MIN_REQUIRED_VERSION = '11.7.0'
No-prompt results on v11.7.0 and v11.8.4 were correct, but are not trustworthy until the above is resolved. Happy to re-test once a new build is available.
Full test plan: https://mattermost.atlassian.net/wiki/x/EAAHHAE
|
The fix would be to update I'd say we keep this PR as-is and accept the QA test results. Unless @enahum you're aware of another solution for the code? |
|
Anything older than the min verdion should show the alert, I understand that is the case, correct? If it is, then is fine |
That's the case 👍 @lindalumitchell Your test results are correct; I'll update the PR description. |
QA Test Steps:
Generated by Claude Code