Fix CRT-off consecutive reply bar 1px offset and vertical overlap.#9932
Fix CRT-off consecutive reply bar 1px offset and vertical overlap.#9932svelle wants to merge 2 commits into
Conversation
Align the consecutive-post avatar spacer to PROFILE_PICTURE_SIZE so same-user thread replies no longer shift the reply bar by 1–2px.
|
@svelle: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsI understand the commands that are listed here |
Coverage Comparison Report |
Each reply post rendered its own translucent (opacity 0.1) bar meant to line up seamlessly with neighboring replies in the same thread. At non-integer device pixel ratios, Yoga rounds each bar's box independently, so adjacent bars can overlap by a device pixel; two translucent layers stacked there blend to a visibly darker line. Baking the blend against centerChannelBg into an opaque color means an accidental 1px overlap draws the same solid color twice instead of compounding it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@enahum lmk if you're not the right person to review this. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughPost list styling now blends theme colours for the reply bar and uses the shared profile picture size constant for consecutive-post spacing, replacing the previous opacity and platform-specific layout values. ChangesPost display styling
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nickmisasi
left a comment
There was a problem hiding this comment.
LGTM - let's ensure this is tested on both Android and iOS
Summary
marginLeft: 34/33instead of the avatar width (PROFILE_PICTURE_SIZE= 32), shifting the reply bar by 1–2pxPROFILE_PICTURE_SIZEso reply bars line up with the first replyRoot cause
In
app/components/post_list/post/post.tsx,consecutivePostContainer.marginLeftwasPlatform.select({ios: 34, android: 33})while a normal avatar column is 32px wide. Webhook icon buffers (which those values appear to mirror) never apply on the consecutive path becauseareConsecutivePostsexcludes webhooks.Testing
Horizontal line issue before:
vertical line issue before:
vertical line issue after: