Skip to content

fix: SeText heading markdown rendering differently from web version #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyanshu-patil wants to merge 1 commit into
base: main
Choose a base branch
from
+71 −0
Open

fix: SeText heading markdown rendering differently from web version #9907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions patches/commonmark+0.31.2-0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
diff --git a/node_modules/commonmark/lib/blocks.js b/node_modules/commonmark/lib/blocks.js
index c25b1c4..af3509d 100644
--- a/node_modules/commonmark/lib/blocks.js
+++ b/node_modules/commonmark/lib/blocks.js
@@ -701,7 +701,7 @@ var blockStarts = [
.match(reSetextHeadingLine))
) {
parser.closeUnmatchedBlocks();
- // resolve reference link definitiosn
+ // resolve reference link definitions
var pos;
while (
peek(container._string_content, 0) === C_OPEN_BRACKET &&
@@ -710,15 +710,52 @@ var blockStarts = [
parser.refmap
))
) {
- container._string_content = container._string_content.slice(
- pos
- );
+ container._string_content = container._string_content.slice(pos);
}
if (container._string_content.length > 0) {
+ // Split accumulated paragraph text into lines. addLine() always
+ // appends a trailing "\n", so drop the empty string that
+ // produces after split.
+ var lines = container._string_content.split("\n");
+ if (lines[lines.length - 1] === "") {
+ lines.pop();
+ }
+
+ // Only the LAST line becomes the setext heading.
+ var headingLine = lines.pop();
+ var remainingLines = lines; // everything before the last line
+
var heading = new Node("heading", container.sourcepos);
heading.level = match[0][0] === "=" ? 1 : 2;
- heading._string_content = container._string_content;
- container.insertAfter(heading);
+ heading._string_content = headingLine;
+
+ if (remainingLines.length > 0) {
+ // Keep preceding lines as their own paragraph, placed
+ // right before the heading.
+ var remainingContent = remainingLines.join("\n") + "\n";
+ var paragraphEndLine =
+ container.sourcepos[0][0] + remainingLines.length - 1;
+ var paragraphEndCol =
+ remainingLines[remainingLines.length - 1].length;
+
+ var remainingParagraph = new Node("paragraph", [
+ container.sourcepos[0],
+ [paragraphEndLine, paragraphEndCol]
+ ]);
+ remainingParagraph._string_content = remainingContent;
+
+ heading._sourcepos = [
+ [paragraphEndLine + 1, container.sourcepos[0][1]],
+ container.sourcepos[1]
+ ];
+
+ container.insertAfter(remainingParagraph);
+ remainingParagraph.insertAfter(heading);
+ } else {
+ // Only one line in the paragraph — behaves as before.
+ container.insertAfter(heading);
+ }
+
container.unlink();
parser.tip = heading;
parser.advanceOffset(