fetch roles during entry to avoid UI observing inconsistent channel s…#9873
Draft
carlisgg wants to merge 1 commit into
Draft
fetch roles during entry to avoid UI observing inconsistent channel s…#9873carlisgg wants to merge 1 commit into
carlisgg wants to merge 1 commit into
Conversation
…tates first time channels are fetched for a team, roles should also be fetched at the same time instead of only relying in deferred fetch. That avoids having channels observed by the UI in an inconsistent state and rendering as read only channels. During reconnection the non forced entry fetch roles is a no-op since force is set to false.
github-actions
Bot
added
the
E2E/Run
Coverage Comparison Report |
github-actions
Bot
removed
the
E2E/Run
enahum
reviewed
Jun 22, 2026
| prepareEntryModels({operator, teamData: initialTeamData, chData, prefData, meData, isCRTEnabled}). | ||
| then((proms) => Promise.all(proms)). | ||
| then((results) => results.flat()), | ||
| fetchRoles(serverUrl, teamData.memberships, chData?.memberships, meData?.user, false, false, groupLabel), |
Contributor
There was a problem hiding this comment.
I'd say is fine if you want to add them here, it does not really mean it will be more realiable, but in any case if you do this probably you want to remove the other fetch call that happens down the line
Contributor
Author
There was a problem hiding this comment.
well, without this I can reproduce the issue in bad network conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetch roles during entry action alongside with channels when needed to avoid UI observing inconsistent channel states and showing channels as read only incorrectly.
Ticket Link
https://mattermost.atlassian.net/browse/MM-67855
Checklist
Device Information
This PR was tested on: Android 16 and iOS 26.1 emulators
Release Note