fix(plan): reject views referencing temporary tables

[iamlinjunhong]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #23700

What this PR does / why we need it:

fix(plan): reject views referencing temporary tables

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[XuPeng-SH]

Reviewed exact head 99a899fea7e15ec9ea17d8acb79b23b3519f095a. The invariant is enforced at the right boundary: validation runs after binding has exposed every reachable scan but before optimizer rewrites can eliminate an effectless temporary-table scan. Direct scans, derived tables, scalar subqueries, WHERE FALSE, and parenthesized SELECTs are covered, and CREATE/REPLACE/ALTER VIEW all share genViewTableDef. Both regular and system temporary table markers are handled, with the original table name preserved in MySQL error 1352. The BVT cleanup change is correct. Full owning package tests for pkg/common/moerr and pkg/sql/plan, go vet, diff checks, and remote CI pass at this head.

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-08-03 09:33 UTC · Rule: main · triggered by rule Automatic queue on approval for main
• 🟠 Checks running · in-place
• 🚫 Left the queue — 2026-08-03 10:13 UTC · at a72730d3d5a26d70ef4136726643f01560f1ddb9

This pull request spent 39 minutes 57 seconds in the queue, with no time running CI.

Waiting for

• any of: [🛡 GitHub branch protection]
  • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
• any of: [🛡 GitHub branch protection]
  • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
  • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • check-success = Matrixone CI / UT Test on Ubuntu/x86
• any of: [🛡 GitHub branch protection]
  • check-neutral = Matrixone CI / SCA Test on Linux/arm64
  • check-skipped = Matrixone CI / SCA Test on Linux/arm64
  • check-success = Matrixone CI / SCA Test on Linux/arm64
• any of: [🛡 GitHub branch protection]
  • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY)
  • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY)
  • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY)
• any of: [🛡 GitHub branch protection]
  • check-neutral = Matrixone Utils CI / Coverage
  • check-skipped = Matrixone Utils CI / Coverage
  • check-success = Matrixone Utils CI / Coverage
• any of: [🛡 GitHub branch protection]
  • check-neutral = Matrixone UT Coverage / UT Coverage on Ubuntu/x86
  • check-skipped = Matrixone UT Coverage / UT Coverage on Ubuntu/x86
  • check-success = Matrixone UT Coverage / UT Coverage on Ubuntu/x86

All conditions

• any of [🛡 GitHub branch protection]:
  • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
• any of [🛡 GitHub branch protection]:
  • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
  • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • check-success = Matrixone CI / UT Test on Ubuntu/x86
• any of [🛡 GitHub branch protection]:
  • check-neutral = Matrixone CI / SCA Test on Linux/arm64
  • check-skipped = Matrixone CI / SCA Test on Linux/arm64
  • check-success = Matrixone CI / SCA Test on Linux/arm64
• any of [🛡 GitHub branch protection]:
  • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY)
  • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY)
  • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY)
• any of [🛡 GitHub branch protection]:
  • check-neutral = Matrixone Utils CI / Coverage
  • check-skipped = Matrixone Utils CI / Coverage
  • check-success = Matrixone Utils CI / Coverage
• any of [🛡 GitHub branch protection]:
  • check-neutral = Matrixone UT Coverage / UT Coverage on Ubuntu/x86
  • check-skipped = Matrixone UT Coverage / UT Coverage on Ubuntu/x86
  • check-success = Matrixone UT Coverage / UT Coverage on Ubuntu/x86
• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • fix(plan): reject views referencing temporary tables #26600
• github-review-approved [🛡 GitHub branch protection]
  • fix(plan): reject views referencing temporary tables #26600

Reason

Pull request #26600 has been dequeued

Pull request from fork cannot be queued. This pull request comes from a fork, and Mergify needs the author's permission to update its branch.

The author needs to enable "Allow edits from maintainers" on this pull request.

Failing checks:

• 🟠 Matrixone CI / SCA Test on Linux/arm64 (job log)
• 🟠 Matrixone CI / UT Test on Ubuntu/x86 (job log)
• 🟠 Matrixone Compose CI / multi cn e2e bvt test docker compose(PROXY) (job log)
• 🟠 Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC) (job log)
• 🟠 Matrixone UT Coverage / UT Coverage on Ubuntu/x86 (job log)

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Tick the box to put this pull request back in the merge queue (same as @mergifyio queue).

• Requeue this pull request