Skip to content

Keep dualboot passwords out of diagnostics and logs - #40

Merged
mateussiqueira merged 1 commit into
mainfrom
fix/dualboot-credential-logging
Oct 30, 2026
Merged

mateussiqueira merged 1 commit into
mainfrom
fix/dualboot-credential-logging

Conversation

@mateussiqueira

Copy link
Copy Markdown
Owner

The final dualboot message passes the account password to info, which writes it to stderr and any configured LOG_FILE. Replace it with a reminder to use the password entered at the prompt, preserving normal operational logging.

Validation: an isolated dualboot flow fails specifically because the old output contains the synthetic password, then passes with the change in both entrypoints and GNU Bash 3.2. The fixture verifies that account creation receives the password, logging remains active, expected target markers/hosts are written, and network preferences stay byte-identical. make ci exits 0 with 122/122 tests and no skips.

Found while preparing diagnostics for #24. No real account or Mac network configuration was changed; this does not establish the cause of its radio failure.

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

Deployment failed for project unleash with the following error:

Resource is limited - try again in 1 day (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/mdap?upgradeToPro=build-rate-limit

@mateussiqueira mateussiqueira left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete diff. Both entrypoints stop passing the password to info while preserving account creation and normal logging. The regression fails at the password-disclosure assertion before the change, passes with Bash 5 and GNU Bash 3.2, and confirms simulated target network preferences remain unchanged. make ci exits 0 with 122/122 tests; its existing optional Markdown command does not validate Markdown in this WSL setup. No physical macOS or Wi-Fi validation is claimed.

@mateussiqueira
mateussiqueira merged commit bf7df36 into main Oct 30, 2026
0 of 4 checks passed
@mateussiqueira
mateussiqueira deleted the fix/dualboot-credential-logging branch October 30, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant