Repository navigation
Keep dualboot passwords out of diagnostics and logs - #40
Merged
Merged
Conversation
|
Deployment failed for project unleash with the following error: Learn More: https://vercel.com/mdap?upgradeToPro=build-rate-limit |
mateussiqueira
commented
Oct 30, 2026
mateussiqueira
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the complete diff. Both entrypoints stop passing the password to info while preserving account creation and normal logging. The regression fails at the password-disclosure assertion before the change, passes with Bash 5 and GNU Bash 3.2, and confirms simulated target network preferences remain unchanged. make ci exits 0 with 122/122 tests; its existing optional Markdown command does not validate Markdown in this WSL setup. No physical macOS or Wi-Fi validation is claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final dualboot message passes the account password to
info, which writes it to stderr and any configured LOG_FILE. Replace it with a reminder to use the password entered at the prompt, preserving normal operational logging.Validation: an isolated dualboot flow fails specifically because the old output contains the synthetic password, then passes with the change in both entrypoints and GNU Bash 3.2. The fixture verifies that account creation receives the password, logging remains active, expected target markers/hosts are written, and network preferences stay byte-identical.
make ciexits 0 with 122/122 tests and no skips.Found while preparing diagnostics for #24. No real account or Mac network configuration was changed; this does not establish the cause of its radio failure.