Skip to content

feat(api): expose max_datastore_keys_query in get_status - #5265

Merged
peterjah merged 2 commits into
mainfrom
5228-expose-max_datastore_keys_query-in-get_status-so-clients-can-size-datastore-key-queries
Sep 16, 2026
Merged

feat(api): expose max_datastore_keys_query in get_status#5265
peterjah merged 2 commits into
mainfrom
5228-expose-max_datastore_keys_query-in-get_status-so-clients-can-size-datastore-key-queries

Conversation

@peterjah

@peterjah peterjah commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@peterjah peterjah linked an issue Sep 11, 2026 that may be closed by this pull request
Expose max_datastore_keys_query in get_status so clients can size datastore key queries #5228
Closed
5 tasks
Leo-Besancon
Leo-Besancon reviewed Sep 11, 2026
View reviewed changes

@Leo-Besancon Leo-Besancon left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. @peterjah @modship even if we'd need to update the protos (only adding the field), do we want the same response in the GRPC API? (to keep the two get_status responses aligned)

@peterjah

peterjah commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

The fix looks good to me. @peterjah @modship even if we'd need to update the protos only adding the field), do we want the same response in the GRPC API? (to keep the two get_status responses aligned)

My bad! i forgot GRPC :) i will add it

@peterjah

peterjah commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

PR on massa-proto
massalabs/massa-proto#82

@peterjah

peterjah commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Pr on massa-proto-rs
massalabs/massa-proto-rs#48

@peterjah
peterjah force-pushed the 5228-expose-max_datastore_keys_query-in-get_status-so-clients-can-size-datastore-key-queries branch from 63ec08f to 6469783 Compare September 14, 2026 13:32
@peterjah
peterjah enabled auto-merge September 14, 2026 13:44
Leo-Besancon
Leo-Besancon reviewed Sep 14, 2026
View reviewed changes
Comment thread massa-models/src/mapping_grpc.rs
Leo-Besancon
Leo-Besancon reviewed Sep 14, 2026
View reviewed changes

@Leo-Besancon Leo-Besancon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the inline comment

@peterjah
peterjah force-pushed the 5228-expose-max_datastore_keys_query-in-get_status-so-clients-can-size-datastore-key-queries branch from 6469783 to bb2b09b Compare September 16, 2026 09:47
@peterjah
peterjah added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit df8be1a Sep 16, 2026
12 checks passed
@Leo-Besancon
Leo-Besancon deleted the 5228-expose-max_datastore_keys_query-in-get_status-so-clients-can-size-datastore-key-queries branch September 21, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes
@modship modship Awaiting requested review from modship

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose max_datastore_keys_query in get_status so clients can size datastore key queries

2 participants

@peterjah @Leo-Besancon