Skip to content

[F23] feat: sync wishlist after pruning - #5263

Merged
Leo-Besancon merged 1 commit into
mainfrom
4986-f23-stale-block-wishlist-entries-persist-after-pruning-due-to-missing-removal-delta
Sep 14, 2026
Merged

Leo-Besancon merged 1 commit into
mainfrom
4986-f23-stale-block-wishlist-entries-persist-after-pruning-due-to-missing-removal-delta

Conversation

@Leo-Besancon

@Leo-Besancon Leo-Besancon commented Sep 7, 2026

Copy link
Copy Markdown
Member
  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Note that Instead of reordering, we sync again after pruning (which seems to be the easiest change to make)

bilboquet
bilboquet previously approved these changes Sep 8, 2026

@bilboquet bilboquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leo-Besancon
Leo-Besancon force-pushed the 4986-f23-stale-block-wishlist-entries-persist-after-pruning-due-to-missing-removal-delta branch from 9cd1d07 to 31d6e8f Compare September 11, 2026 06:34

@bilboquet bilboquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good

@Leo-Besancon
Leo-Besancon added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit 752b1b7 Sep 14, 2026
12 checks passed
@Leo-Besancon
Leo-Besancon deleted the 4986-f23-stale-block-wishlist-entries-persist-after-pruning-due-to-missing-removal-delta branch September 15, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F23] Stale Block Wishlist Entries Persist After Pruning Due to Missing Removal Delta

2 participants