Conversation
…imits stay bounded
…allows-bypassing-query-limits-and-dos
Collaborator
Author
|
It appears massa-web3 Grpc does not implements the pagination.. but i dont think its used widely. |
Member
For this point, isn't it the same as #5189? What's the difference? |
Collaborator
Author
Exact same thing it seems 😸 The thing i didnt pointed last time is that its conerns the newly created getDatastoreKey, that was build especially to replace the old get_addresses that was not paginated. |
Collaborator
Author
|
As this PR seems a duplicate of #5189 i think i will report my comments there and close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…imits stay bounded
Breaking in effect:
respectively).
answer. That's the real sharp edge: a client with >500 keys under the queried prefix would need to switch to paginating via start_key, and nothing in the response tells it to.
Because we build the getDatastoreKeys endpoint recently, I am pretty confident that pagination is well supported by clients