Fix Emscripten build with SIMD - #95
Merged
Merged
Conversation
marton78
force-pushed
the
fix-emscripten-build
branch
from
April 22, 2026 08:03
2eccc75 to
a1546d0
Compare
Applies fully qualified namespace syntax throughout the codebase to ensure std:: references are unambiguous, especially in contexts where user namespaces may define conflicting std symbols. Fixes #65 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add !defined(SIMD_SZ) guard to pf_neon_float.h and pf_altivec_float.h, matching the guard already present in pf_sse1_float.h. This prevents redefinition errors when multiple SIMD backends match (e.g. Emscripten with -msimd128 enabling SSE while __arm__ and PFFFT_ENABLE_NEON are also defined). Fixes #94 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Detect Emscripten in CMake and pass -msimd128, which activates Emscripten's NEON-to-WASM-SIMD compatibility layer (arm_neon.h mapped to wasm_simd128 intrinsics). This lets the existing NEON code path produce WASM SIMD output without source changes. Also fix ctest for cross-compiled targets: - Use target names in add_test() so CMake prepends CMAKE_CROSSCOMPILING_EMULATOR (node) when running .js outputs - Add -sALLOW_MEMORY_GROWTH=1 for test_pffastconv to prevent OOM in benchmark mode Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fft_cpp_11 with ctest These executables were built but never registered as tests, so ctest never ran them. Uses bare target names so CMAKE_CROSSCOMPILING_EMULATOR is applied automatically (needed for Emscripten/node). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marton78
force-pushed
the
fix-emscripten-build
branch
from
April 22, 2026 09:22
a1546d0 to
8c4b979
Compare
marton78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
!defined(SIMD_SZ)guard to NEON and Altivec headers, matching the guard already present inpf_sse1_float.h. This prevents redefinition errors when multiple SIMD backends match (e.g. Emscripten with-msimd128enabling SSE while__arm__andPFFFT_ENABLE_NEONare also defined).Fixes #94