Skip to content

Do not simply rely on the compiler to check if we should link with the math library #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marton78 merged 2 commits into from
Apr 13, 2026
Merged

Do not simply rely on the compiler to check if we should link with the math library #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cffe39
[CMAKE] Fix #92: do not simply rely on the compiler to check if we sh…
G4m4 Mar 20, 2026
6a0d01e
[CMAKE] Take into account opt-out option for math lib link and have m…
G4m4 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,21 +107,31 @@ endif(NOT CMAKE_BUILD_TYPE)

if ( CMAKE_C_COMPILER_ID MATCHES "MSVC" )
# using Visual Studio C++
message(STATUS "INFO: detected MSVC: will not link math lib m")
set(MATHLIB "")

add_definitions("/D_CRT_SECURE_NO_WARNINGS")

set(MSVC_DISABLED_WARNINGS_LIST
"C4996"
)
endif()

else()
if(PFFFT_DISABLE_LINK_WITH_M)
# The math library is only required on Unix
if(NOT WIN32 AND NOT APPLE)
find_library(MATH_LIBRARY m)
if(MATH_LIBRARY)
if(PFFFT_DISABLE_LINK_WITH_M)
set(MATHLIB "")
message(STATUS "INFO: will not link math lib m as it is disabled")
else()
message(STATUS "INFO: detected Unix and found library: ${CMAKE_C_COMPILER_ID} will link math lib m")
set(MATHLIB ${MATH_LIBRARY})
endif()
else()
message(STATUS "INFO: detected NO MSVC: ${CMAKE_C_COMPILER_ID}: will link math lib m")
set(MATHLIB "m")
set(MATHLIB "")
message(WARNING "Could not find math lib m")
endif()
else()
set(MATHLIB "")
message(STATUS "INFO: will not link math lib m, no need for this target")
endif()

set(STDCXXLIB "")
Expand Down
Loading