Skip to content

Fix "INSTALL(EXPORT) given unknown export "pffft-targets" " #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marton78 merged 2 commits into from
Mar 10, 2026
Merged

Fix "INSTALL(EXPORT) given unknown export "pffft-targets" " #89

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91fc6c
[CMAKE] Make the install command optional to prevent an error during …
G4m4 Mar 10, 2026
0d815eb
[CMAKE] Conditional on actual variable emptiness + add more install c…
G4m4 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,11 +296,15 @@ install( TARGETS ${INSTALL_TARGETS}
)
install( FILES ${INSTALL_HEADERS} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/pffft)

install(EXPORT pffft-targets
FILE pffft-targets.cmake
NAMESPACE PFFFT::
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/pffft
)
if (INSTALL_PFFFT)

@marton78 marton78 Mar 10, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guard variable here should be INSTALL_TARGETS rather than INSTALL_PFFFT.

INSTALL_TARGETS can be non-empty even when INSTALL_PFFFT=OFF — for example if INSTALL_PFDSP=ON or INSTALL_PFFASTCONV=ON. In those cases, targets are added to the pffft-targets export set (so the export exists), but this guard would suppress writing pffft-targets.cmake, breaking the install for those components.

The semantically correct condition is whether any target was actually added to the export set:

if (INSTALL_TARGETS)
  install(EXPORT pffft-targets
    FILE pffft-targets.cmake
    NAMESPACE PFFFT::
    DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/pffft
  )
endif()

This is also more robust across CMake versions, where the behaviour of install(TARGETS "" EXPORT foo) with an empty list is not consistently specified.

# If ${INSTALL_TARGETS} is empty, then the export "pffft-targets" will
# not exist and the following command will fail so we must make it conditional
install(EXPORT pffft-targets
FILE pffft-targets.cmake
NAMESPACE PFFFT::
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/pffft
)
endif()

include(CMakePackageConfigHelpers)

Expand Down