Conversation
…to src/ Move public API headers to include/pffft/ for namespaced includes (#include <pffft/pffft.h>), implementation files and private headers to src/, and SIMD backends to src/simd/. Update CMakeLists.txt with proper PUBLIC/PRIVATE include directories and fix all include paths in tests, benchmarks, and examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace hardcoded lib/ and include/ destinations with CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR for portable, distro-friendly install layout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update all target_include_directories INSTALL_INTERFACE paths from
hardcoded "include" to ${CMAKE_INSTALL_INCLUDEDIR} so installed
packages resolve headers correctly on all platforms.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add install(EXPORT) to generate target export files, and create pffft-config.cmake.in with CMakePackageConfigHelpers so that downstream projects can use find_package(pffft) and link against PFFFT::PFFFT after install. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove hardcoded STATIC from add_library() for PFFFT, PFDSP, and
PFFASTCONV so BUILD_SHARED_LIBS controls the library type. FFTPACK
targets remain static (internal, not installed).
Add export macros (PFFFT_EXPORT, PFDSP_EXPORT, PFFASTCONV_EXPORT)
inline in each public header to handle dllexport/dllimport on Windows
and visibility("default") on GCC/Clang. The macros are self-contained
with no generated headers, so the library builds with any build system
or plain compiler invocation.
CMake sets hidden visibility by default for shared builds and defines
*_STATIC_DEFINE for static builds. *_EXPORTS is set automatically by
CMake when building shared libraries.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.