Added schema for Dolphiq/craft3-iconpicker#193
Conversation
|
This is cool! The enum values look a little odd to me, though. I would recommend taking the GraphQL approach of upper casing them, like: Other than that this is good to merge. Thoughts? |
|
Good point, however I feel since I want to keep it inline with how the original plugin uses it in templating dropping the "icon" part. So instead of iconCharHex, just CharHex |
|
I'll vote once again to |
|
Agree, will change to lcfirst |
|
Changes made. Also, changed default to Char since that is most likely what I believe users will want |
|
Ready to merge? |
No description provided.