Skip to content

Restore active navigation on CarPlay when it is connected #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
S2Ler merged 1 commit into from
May 15, 2022
Merged

Restore active navigation on CarPlay when it is connected #3865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
### CarPlay

* Fixed an issue where an active navigation using CarPlay application with route that contains multiple legs would cause a memory leak. ([#3877](https://github.com/mapbox/mapbox-navigation-ios/pull/3877))
* Added the `CarPlayManagerDelegate.carPlayManager(_:shouldUpdateNotificationFor:with:in:)` and `CarPlayManagerDelegate.carPlayManager(_:shouldShowNotificationFor:in:)` to provide the ability to control notifications presentation while CarPlay application is in the background. ([#3828](https://github.com/mapbox/mapbox-navigation-ios/pull/3828))

### Other Changes
* During turn-by-turn navigation, incidents along the route are now refreshed periodically along with traffic congestion.
Expand Down
5 changes: 5 additions & 0 deletions Example/AppDelegate+CarPlay.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,11 @@ class CarPlaySceneDelegate: NSObject, CPTemplateApplicationSceneDelegate {
appDelegate.carPlayManager.templateApplicationScene(templateApplicationScene,
didConnectCarInterfaceController: interfaceController,
to: window)
// NOTE: When CarPlay is connected, we check if there is an active navigation in progress and start CarPlay
// navigation as well, otherwise, CarPlay will be in passive navigation and stay out of sync with iOS app.
if appDelegate.currentAppRootViewController?.activeNavigationViewController != nil {
Comment thread
S2Ler marked this conversation as resolved.
Comment thread
S2Ler marked this conversation as resolved.
appDelegate.currentAppRootViewController?.beginCarPlayNavigation()
}
}

func templateApplicationScene(_ templateApplicationScene: CPTemplateApplicationScene,
Expand Down