magento/magento2#32805: Fix catalog rule negative conditions for missing values - #41116
Open
swnsma wants to merge 2 commits into
Open
magento/magento2#32805: Fix catalog rule negative conditions for missing values#41116swnsma wants to merge 2 commits into
swnsma wants to merge 2 commits into
Conversation
Negative catalog price rule conditions (is not, does not contain, is not one of) now match products with missing or empty attribute values. Multiselect gains an "is undefined" operator; inverse "is defined" is expressed via a FALSE combine.
|
Hi @swnsma. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Drop apply-button click for multiselect condition values and open Actions via the fieldset selector used by core catalog rule MFTFs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Manual testing scenarios
Questions or comments
Negative catalog price rule conditions (
!=,!{},!()) previously excluded products with no EAV row / empty value because SQL filters only saw rows that existed in the attribute tables, and PHP validation treated missing values as non-matching.This change:
EavAttributeCondition).<=>) in PHP validation.<=>→is_nulland reversesis_null↔notnullfor FALSE combines (“is defined” without a separate operator).RuleSQL builder negatives /<=>for Catalog Widget (and shared rule SQL).Coverage: unit + integration (matching IDs, collection SQL path, rule price, widget, sales rule) + MFTF for category is not, multiselect does not contain, and multiselect is undefined.