Repository navigation
Potential fix for code scanning alert no. 1–2: Workflow does not contain permissions - #192
Merged
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
m13253
marked this pull request as ready for review
October 21, 2026 10:47
Owner
Author
|
These two changes are created by GitHub’s CodeQL auto scanner. They look trivial and seems no side-effects. So they look good to me, merging. |
m13253
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/m13253/dns-over-https/security/code-scanning/1 and https://github.com/m13253/dns-over-https/security/code-scanning/2
Add an explicit
permissionsblock to this workflow so theGITHUB_TOKENis constrained by least privilege.Best fix here (without changing behavior) is to set workflow-level permissions to read-only for repository contents:
.github/workflows/*.yml.on:and beforejobs:) apermissions:block with:contents: readThis applies to all jobs in this workflow (including
build) unless overridden later, and is the minimal safe baseline recommended by CodeQL.Suggested fixes powered by Copilot Autofix. Review carefully before merging.