Skip to content

fix: publish ESM-only package - #60

Closed
f0rdream wants to merge 1 commit into
lynx-community:mainfrom
f0rdream:feat/esm-only-package
Closed

f0rdream wants to merge 1 commit into
lynx-community:mainfrom
f0rdream:feat/esm-only-package

Conversation

@f0rdream

Copy link
Copy Markdown
Collaborator

Publish @lynx-js/react-use as a bundleless ESM-only package for Rspeedy/Rspack consumers. Remove the CommonJS build and export, point the package entry to the ESM artifact, and make the tree-shaking coverage resolve through the public package exports. This also removes the dual-package declaration warning.

@netlify

netlify Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for reactlynx-use ready!

Name Link
🔨 Latest commit 6e4c778
🔍 Latest deploy log https://app.netlify.com/projects/reactlynx-use/deploys/6a5f4104e7edcc0007a6d6a6
😎 Deploy Preview https://deploy-preview-60--reactlynx-use.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the @lynx-js/react-use package to be ESM-only by removing CommonJS support, updating package.json entry points, removing the CJS build configuration from rslib.config.ts, and updating the tree-shaking tests. The reviewer correctly points out that because removing CommonJS support is a breaking change, the changeset should specify a major version bump instead of a minor bump to comply with Semantic Versioning.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .changeset/bright-lynxes-import.md Outdated
@@ -0,0 +1,5 @@
---
"@lynx-js/react-use": minor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Since this pull request removes CommonJS support and is explicitly marked as a breaking change (feat!:), the changeset should specify a major version bump instead of minor to comply with Semantic Versioning (SemVer).

Suggested change
"@lynx-js/react-use": minor
"@lynx-js/react-use": major

@f0rdream
f0rdream force-pushed the feat/esm-only-package branch from 03a9fd4 to 6e4c778 Compare July 21, 2026 09:50
@f0rdream f0rdream changed the title feat!: publish ESM-only package fix: publish ESM-only package Jul 21, 2026
@f0rdream

Copy link
Copy Markdown
Collaborator Author

Closing for now since the Publint message is non-blocking and the current package remains publishable.

@f0rdream f0rdream closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant