Fix user bootloader support check

[Daniiiil1]

Summary

• reuse isUserBootloaderSupported() before sending the user-bootloader query
• preserve the bootloader-version guard while also enforcing the NETWORK-only requirement
• avoid sending an unsupported request to USB bootloaders with a sufficiently new version

Validation

• configured and built depthai-core successfully on macOS with optional OpenCV, dynamic calibration, events manager, and MP4 support disabled
• verified src/device/DeviceBootloader.cpp compiles and the final libdepthai-core.a links
• clang-format --dry-run --Werror src/device/DeviceBootloader.cpp
• git diff --check

Hardware validation was not run because an OAK device is not available locally.

Closes #1102

Summary by CodeRabbit

• Bug Fixes
  • Improved bootloader capability checks to ensure requests are sent only when the bootloader type and version are supported.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8ecf4964-cad4-49d1-a004-fc9675cce4b9

📥 Commits

Reviewing files that changed from the base of the PR and between f9bb49f and abbaf55.

📒 Files selected for processing (1)

• src/device/DeviceBootloader.cpp

📜 Recent review details

🔇 Additional comments (1)

src/device/DeviceBootloader.cpp (1)

706-708: LGTM!

---

📝 Walkthrough

Walkthrough

isUserBootloader() now uses isUserBootloaderSupported() before it sends the user-bootloader request. This replaces the previous version-only check.

Changes

User bootloader validation

Layer / File(s)	Summary
Apply shared bootloader support check src/device/DeviceBootloader.cpp	isUserBootloader() now validates the bootloader type and version through isUserBootloaderSupported() before sending the request.

Estimated code review effort: 2 (Simple) | ~5 minutes

Poem

A rabbit checks the bootloader gate,
Type and version must validate.
No request hops through too soon,
The shared check keeps logic in tune.
Carrot-approved, the path is clear.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: fixing the user bootloader support check.
Linked Issues check	✅ Passed	The change reuses isUserBootloaderSupported() to enforce bootloader version and NETWORK-only requirements from issue #1102.
Out of Scope Changes check	✅ Passed	The change is limited to the requested user bootloader support validation and contains no unrelated code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}