Skip to content

Support for setting external strobe exposure master camera #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sb-lxn wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Support for setting external strobe exposure master camera #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d76f184
Initial support for setting external exposure master camera
sb-lxn Jun 23, 2026
65329d7
Docstring
sb-lxn Jun 23, 2026
38a775a
Merge remote-tracking branch 'origin/develop' into feat/externalStrob…
sb-lxn Aug 12, 2026
be8c4aa
Merge remote-tracking branch 'origin/develop' into feat/externalStrob…
sb-lxn Aug 14, 2026
947885a
bump device
sb-lxn Aug 14, 2026
3323469
Fix bindings
sb-lxn Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bindings/python/src/DeviceBindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,14 @@ void DeviceBindings::bind(pybind11::module& m, void* pCallstack) {
},
py::arg("enable"),
DOC(dai, DeviceBase, setExternalStrobeEnable))
.def(
"setExternalStrobeEnable",
[](DeviceBase& d, dai::CameraBoardSocket exposureMasterSocket) {
py::gil_scoped_release release;
d.setExternalStrobeEnable(exposureMasterSocket);
},
py::arg("exposureMasterSocket"),
DOC(dai, DeviceBase, setExternalStrobeEnable, 2))
.def(
"getDeviceName",
[](DeviceBase& d) {
Expand Down
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceRVC4Config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
set(DEPTHAI_DEVICE_RVC4_MATURITY "snapshot")

# "version if applicable"
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+d2d6c8dfc32299a1c5bc9d2b00aed160d00bce42")
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+b4f834a11d748903ad6d1f6021ee0c9ef1fa3a1a")
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceSideConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set(DEPTHAI_DEVICE_SIDE_MATURITY "snapshot")

# "full commit hash of device side binary"
set(DEPTHAI_DEVICE_SIDE_COMMIT "fe324863aff547d4564ece9b5d761f60c499dba2")
set(DEPTHAI_DEVICE_SIDE_COMMIT "068e34c3b29fff5e286e6c0a7afdfc36871a07ba")

# "version if applicable"
set(DEPTHAI_DEVICE_SIDE_VERSION "")
7 changes: 7 additions & 0 deletions include/depthai/device/DeviceBase.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,6 +1216,13 @@ class DeviceBase {
*/
void setExternalStrobeEnable(bool enable);

/**
* Set which camera will control the external strobe exposure. Automaticaly enables external strobe.

@coderabbitai coderabbitai Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix typo in documentation.

Line 1163 contains a typo: "Automaticaly" should be "Automatically".

📝 Proposed fix 
-     * Set which camera will control the external strobe exposure. Automaticaly enables external strobe.
+     * Set which camera will control the external strobe exposure. Automatically enables external strobe.

Note: The previous review comment regarding clarifying the documentation has been addressed—the wording now clearly states this overload selects which camera controls the strobe and automatically enables it.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* Set which camera will control the external strobe exposure. Automaticaly enables external strobe.
* Set which camera will control the external strobe exposure. Automatically enables external strobe.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@include/depthai/device/DeviceBase.hpp` at line 1163, In the documentation
comment for the external strobe exposure control method around line 1163 in
DeviceBase.hpp, fix the spelling error where "Automaticaly" is misspelled.
Change it to "Automatically" in the comment that reads "Set which camera will
control the external strobe exposure. Automaticaly enables external strobe."

* External strobe signal is low for the duration of exposure, and high for the rest of the frame.
* @param exposureMasterSocket CameraBoardSocket of the camera which will control the external strobe exposure
*/
Comment thread
coderabbitai[bot] marked this conversation as resolved.
void setExternalStrobeEnable(dai::CameraBoardSocket exposureMasterSocket);

/**
* Mock camera features from a recording. Used for holistic record and replay.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/device/DeviceBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,6 +1740,10 @@ void DeviceBase::setExternalStrobeEnable(bool enable) {
pimpl->rpcCallCheckedVoid("setExternalStrobeEnable", enable);
}

void DeviceBase::setExternalStrobeEnable(dai::CameraBoardSocket exposureMasterSocket) {
pimpl->rpcCallCheckedVoid("setExternalStrobeEnableExposureMaster", exposureMasterSocket);
}

dai::Version DeviceBase::getIMUFirmwareVersion() {
isClosed();
std::string versionStr = pimpl->rpcCallChecked<std::string>("getIMUFirmwareVersion");
Expand Down
Loading