Feat/rnc content-position annotations and non-leading start - #32
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves RELAX NG Compact (RNC) parsing and RNG XML emission around two tricky edge cases: bracket annotations that appear in “content positions” and start definitions that appear after other grammar items (including |=/&= combining starts).
Changes:
- Extend the RNC parser to skip bracket annotations before content items / definitions without capturing them into the parse tree, and tighten top-level sequence parsing to require commas.
- Update the RNC→RNG converter to emit a real
<start>element for non-leadingstart =/start |=/start &=definitions (and preserve escaped\startas a normal<define>). - Add advanced specs covering content-position annotations, non-leading
start, combining starts, and escaped\start.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/rng/advanced_rnc_spec.rb | Adds regression/feature specs for annotation-skipping and non-leading/combining start handling. |
| lib/rng/rnc_to_rng_converter.rb | Refactors start emission and adds detection/emission for non-leading start definitions. |
| lib/rng/rnc_parser.rb | Adds annotation_skip and uses it to drop content-position annotations; requires commas for top-level sequence items in pattern_list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<start>for non-leadingstart =definitions|=→ choice,&=→ interleave\startas a regular define