Skip to content

refactor(lsp7): rename music extension to LSP7MusicNDT - #1154

Open
emmet-bot wants to merge 1 commit into
lukso-network:mainfrom
emmet-bot:fix/music-ndt-rename-20261023
Open

emmet-bot wants to merge 1 commit into
lukso-network:mainfrom
emmet-bot:fix/music-ndt-rename-20261023

Conversation

@emmet-bot

Copy link
Copy Markdown
Collaborator

Summary

  • Follow up on merged Add LSP33 Music NFT extensions for LSP7 and LSP8 #1088: rename the LSP7 music extension family from LSP7MusicNFT to LSP7MusicNDT, including filenames, imports, mocks, tests and NatSpec.
  • Keep LSP8MusicNFT unchanged. The LSP7 name describes multiple non-divisible units when deployed with isNonDivisible_ = true; the constructor flag remains configurable and no new enforcement is introduced.
  • Preserve all LSP33/LSP34 keys, mint delegation, ownership and executable behaviour.

Verification

  • Independent Claude Opus 5.5 review passed.
  • 629 LSP7/LSP8 Foundry tests passed (327 + 302); 74 music tests (52 + 22).
  • Added a regression for multiple non-divisible units and unchanged configurable divisibility.
  • solc 0.8.28 metadata-off comparison: unchanged creation/runtime bytecode, ABI and all 21 selectors.
  • Prettier, solhint and diff whitespace checks passed; tests explicitly resolve current-tree @lukso sources.
  • Live CI will be verified after publication.

Spec implementation references: lukso-network/LIPs#321

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant