OSW-2418: Add clamping around glass temperature.#89
Merged
Conversation
bbrondel
force-pushed
the
tickets/OSW-2418
branch
from
eac7f0c to
5c44a8c
Compare
bstalder
requested changes
Jun 10, 2026
bbrondel
force-pushed
the
tickets/OSW-2418
branch
from
72d7ef0 to
1f117cf
Compare
bstalder
approved these changes
Jun 10, 2026
bstalder
left a comment
bstalder
left a comment
There was a problem hiding this comment.
looks good, the init values are removed, so defaults are set properly. heaters and glycol offsets look like they should track together.
bbrondel
force-pushed
the
tickets/OSW-2418
branch
from
1f117cf to
6f16d7a
Compare
pkubanek
reviewed
Jun 10, 2026
bbrondel
force-pushed
the
tickets/OSW-2418
branch
from
6f16d7a to
c62f3bd
Compare
bbrondel
force-pushed
the
tickets/OSW-2418
branch
from
c62f3bd to
2160c53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change constrains the commanded M1M3 heater setpoint to a configurable offset band around the median M1M3 glass temperature. The band is defined by the configuration items
glass_offset_limit_lowandglass_offset_limit_high.