Add a temporary copy of the MTDome louver table, as a fallback until it is available in the ts_xml conda package.#87
Merged
Conversation
bstalder
reviewed
May 28, 2026
bstalder
left a comment
bstalder
left a comment
There was a problem hiding this comment.
needed temporary louver table to facilitate EAS control.
wvreeven
requested changes
May 28, 2026
wvreeven
left a comment
wvreeven
left a comment
Collaborator
There was a problem hiding this comment.
Please do not use the term fallback.
| @@ -0,0 +1 @@ | |||
| Added a temporary copy of the MTDome louver table, as a fallback until it is available in the ts_xml conda package. | |||
Collaborator
There was a problem hiding this comment.
Here and everywhere else in the code changes: please do not use the term fallback. Tiago has explained that we refer to this kind of construction as making the code backward compatible with the current XML release so please use that term instead.
…ibility until it is available in the ts_xml conda package.
bbrondel
force-pushed
the
tickets/OSW-2358
branch
from
6f65de6 to
b223e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR temporarily includes the louver table as part of ts_eas. When it becomes available in ts_xml it should be removed from here.