OSW-2348: Add frequency control via configFan when enabling VEC-04.#85
Merged
Conversation
bstalder
approved these changes
May 27, 2026
bstalder
left a comment
There was a problem hiding this comment.
fixed mis-configuration of VEC fan (should have explicit VFD frequency) command.
5a807f4 to
178d47b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds control of the VEC-04 fan frequency via
configFan. Currently a fixed (configurable) frequency is applied whenever the fan is turned on, defaulting to 55 Hz. No command is applied to set the fan frequency when it is turned off.