OSW-2237: Add configurable closed_at_night setpoint cadence, rename closedatnite, drop unused glycol_forecast_active flag.#84
Merged
Conversation
…e, drop unused glycol_forecast_active flag.
bstalder
approved these changes
May 26, 2026
bstalder
left a comment
bstalder
left a comment
There was a problem hiding this comment.
update labels, remove setpoint active feature, added closed dome cadence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles several small tasks for EAS:
glycol_forecast_activeflag in HvacModel.It will be necessary to migrate the changes in ts_config_ocs at the same time, and EAS live on the summit will need to switch to a branch to avoid compatibility breaks. A PR has been set up in ts_config_ocs. Currently summit is using v0.28.61 with modifications.
The Jira tickets covered by this PR are:
glycol_forecast_activeflag