[nix] add some missing devshell dependencies - #30839
Merged
Merged
Conversation
Contributor
|
I'm a bit confused about the log in the PR description. You ran with |
rswarbrick
reviewed
Jul 24, 2026
Contributor
Author
Sorry fixed the "log". Copied the command you gave me to test this. Fixed the build stage issues. Then dropped the build only flag and ran it all the way through. When writing the description in the PR I copied your original command and forgot to remove the build only flag. Locally I ran it without... hence the tail of the log with 5 sims passing in addition to the one build job. |
engdoreis
reviewed
Jul 27, 2026
engdoreis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the addition.
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
andreaskurth
approved these changes
Jul 27, 2026
andreaskurth
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @machshev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this update I'm able to run the following dvsim sim flow: