Skip to content

fix: return error responses for funding source without description_hash #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackcoffeexbt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return error responses for funding source without description_hash #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions views_lnurl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@

from fastapi import APIRouter, HTTPException, Query, Request
from lnbits.core.services import create_invoice
from lnbits.exceptions import InvoiceError
from lnbits.utils.exchange_rates import get_fiat_rate_satoshis
from lnbits.wallets import get_funding_source
from lnbits.wallets.base import Feature
from lnurl import (
CallbackUrl,
LightningInvoice,
Expand Down Expand Up @@ -111,14 +114,26 @@ async def api_lnurl_callback(

# we take the zap request as the description instead of the metadata if present
unhashed_description = nostr.encode() if nostr else metadata.encode()
funding_source = get_funding_source()
if (
funding_source.features is not None
and not funding_source.has_feature(Feature.descriptionhash)

@dni dni Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no feature for Feature.descriptionhash? am i missing something?

):
return LnurlErrorResponse(
reason="This payment link cannot receive payments with its current configuration."
)

try:
payment = await create_invoice(
wallet_id=link.wallet,
amount=int(amount / 1000),
memo=link.description,
unhashed_description=unhashed_description,
extra=extra,
)
except InvoiceError as exc:
return LnurlErrorResponse(reason=exc.message)

payment = await create_invoice(
wallet_id=link.wallet,
amount=int(amount / 1000),
memo=link.description,
unhashed_description=unhashed_description,
extra=extra,
)
invoice = parse_obj_as(LightningInvoice, LightningInvoice(payment.bolt11))

if link.success_url:
Expand Down
Loading