Skip to content

[WIP] Mpi-Pingpong Benchmark - #726

Open
michaelmckinsey1 wants to merge 77 commits into
developfrom
benchmark/mpi-pingpong
Open

[WIP] Mpi-Pingpong Benchmark#726
michaelmckinsey1 wants to merge 77 commits into
developfrom
benchmark/mpi-pingpong

Conversation

@michaelmckinsey1

@michaelmckinsey1 michaelmckinsey1 commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Description

Adding/modifying a system (docs: Adding a System)

  • Update llnl-*/system.py with sys_sockets_per_node parameter

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • Add mpi-pingpong benchmark
  • Update package.py to work with Spack 1.0 @scheibelp -> The package works - michael

@michaelmckinsey1 michaelmckinsey1 changed the title Mpi-Pingpong Benchmark [WIP] Mpi-Pingpong Benchmark Apr 8, 2025
Comment thread repo/mpi-pingpong/package.py Outdated
@github-actions github-actions Bot added the system New or modified system config label Apr 30, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this May 2, 2025
@michaelmckinsey1

Copy link
Copy Markdown
Collaborator Author

Running trials in the same allocation parameter (ramble) https://ramble.readthedocs.io/en/latest/workspace_config.html#experiment-repeats

Comment thread experiments/mpi-pingpong/experiment.py Outdated
@github-actions github-actions Bot added the feature New feature or request label Jun 6, 2025

@scheibelp scheibelp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(changes here look compatible w/ #953)

@michaelmckinsey1

Copy link
Copy Markdown
Collaborator Author

Currently this is out of sync with develop in order to run on lassen (pre spack 1.0 PR).

depends_on("adiak", when="+caliper")
depends_on("hip", when="+rocm")
depends_on("cuda", when="+cuda")

@michaelmckinsey1 michaelmckinsey1 Oct 17, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will probably need this for spack 1.0

Suggested change
depends_on("c", type="build")
depends_on("cxx", type="build")

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.43%. Comparing base (6ab499b) to head (2aea1b6).
⚠️ Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #726   +/-   ##
========================================
  Coverage    65.43%   65.43%           
========================================
  Files           44       44           
  Lines         3240     3240           
  Branches       256      256           
========================================
  Hits          2120     2120           
  Misses        1113     1113           
  Partials         7        7           
Files with missing lines Coverage Δ
systems/llnl-elcapitan/system.py 36.29% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application docs Improvements or additions to documentation experiment New or modified experiment feature New feature or request system New or modified system config WIP A work-in-progress not yet ready to commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants