chore: remove tdd-guardian plugin footprint from the repo - #2016
Closed
lllyys wants to merge 2 commits into
Closed
Conversation
The tdd-guardian gate has been non-enforcing for months (enforceOnTaskCompleted
false; warn-only PreToolUse) and is redundant with the repo's real test
authority: rule 10's Gate-3 run-tests.sh discipline (inline) + rule 55's
orchestrator independent re-run (dispatch, never trusts a HANDOFF's pass claim).
Reviewed by a 5-angle grill + two Codex passes → full-removal.
The plugin stays ENABLED GLOBALLY (user ~/.claude.json, untouched) — this only
removes its footprint from THIS repo:
- Disable it for the repo: .claude/settings.json enabledPlugins
"tdd-guardian@xiaolai": false (project settings take precedence over global,
so vreader sessions stop loading its ~14 skills + 7 agents; other repos
unaffected).
- Delete the dead wrapper scripts/tdd-guardian-test.sh + its test, and the
project config .claude/tdd-guardian/{config,state}.json. The wrapper's ONLY
caller was the guardian's testCommand; its platform routing is a thin call
into the shared code_paths_platform classifier, which the merge hooks + skills
already use directly.
- Fix the now-dangling references in active docs: rule 10, AGENTS.md,
.claude/README.md (tree + Guardian Configs), .gitignore (dead state.json
ignore), ADR 0001 (stale example).
NOT touched (intentional): canon/* (rule 56 — the staleness sweep records the
deleted artifact as missing: and demotes automation-tooling.md to stale; the
next compile reconciles — never hand-edited) and historical records
(dev-docs/plans, dev-docs/verification, .claude/codex-audits, the #107 row in
docs/features.md — they record what was true then).
Codex audit of the diff: clean.
Owner
Author
|
Superseded — direction reversed. Rather than removing tdd-guardian, we're keeping the whole xiaolai plugin suite active and thinning the bespoke rules/workflow that duplicate the plugins' capabilities (thin to a binding stub + 'see plugin X' pointer). A rules-thinning PR replaces this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the tdd-guardian plugin's repo footprint (keep it enabled globally)
Removes the dead tdd-guardian gate from this repo while leaving the plugin enabled globally in the user's
~/.claude.json(untouched). Reviewed by a 5-angle reason-grill + two independent Codex passes → full-removal; the removal diff itself audited clean.Why it's dead + redundant
enforceOnTaskCompleted: false+ a warn-only PreToolUse hook = it hasn't gated anything for months (through the entire successful docs: require a version bump in every PR + bump to 3.10.2 #131–docs(AGENTS): merge gate — PRs referencing an open bug/feature don't ship alone #138 push).run-tests.shdiscipline (inline flows) + rule 55's orchestrator independent re-run of the declared suite (dispatch — never trusts a HANDOFF's "tests passed" claim). The guardian's whole value proposition is already delivered, more authoritatively, elsewhere.scripts/tdd-guardian-test.shexisted only to stop the guardian's statictestCommandfalse-greening a Kotlin change on the frozen iOS command; its ONLY caller was the guardian config, and its platform routing is a thin call into the sharedcode_paths_platformclassifier the merge hooks + skills already use directly.What this PR does
.claude/settings.json→"tdd-guardian@xiaolai": false. Project settings take precedence over global, so vreader sessions stop loading its ~14 skills + 7 agents (the actual context-tax saving); other repos are unaffected.scripts/tdd-guardian-test.sh+ its test +.claude/tdd-guardian/{config,state}.json(all four were tracked; the wrapper had no other caller)..claude/README.md(tree + Guardian Configs),.gitignore(deadstate.jsonignore), ADR 0001 (stale example).Intentionally NOT touched
canon/*(rule 56): canon is reconciled by the staleness sweep, never hand-edited. Verifiedcanon-staleness.shrecords the deleted artifact asmissing:→ demotescanon/modules/automation-tooling.mdverified → stale(no crash); the next compile removes the entry. Flagged here so it reads as intentional deferral, not an oversight..claude/codex-audits, the Bug #78: Highlight visual persists after deletion #107 row indocs/features.md) — they record what was true when written.Notes
3.67.7 → 3.67.9— sequences after held PR chore(orchestration): rule 57 within-WI fan-out + ANDROID_SERIAL routing + android lease #2015 (3.67.8); if merge order differs, a rebase reconciles./pluginaction and is not part of this PR (you chose to keep it enabled everywhere else).Held for review — do not merge yet.