Conversation
- explicitly include all modifiers when changing columns in migrations - remove security advisory overrides - remove doctrine/dbal - specify a more precise version for debugbar
Contributor
|
Xampp doesn't have an 8.3 release, we should likely wait until that's out |
Member
Author
|
Yeah, that makes sense. |
Member
|
fwiw it is dead simple to change the PHP version in XAMPP. In fact, it's so simple, I don't know why they don't have an 8.3 version yet? All you do is go to the PHP website, download the non-thread-safe windows .zip file for 8.3, and replace the "php" folder in xampp with the contents of that zip file. I've done it to get PHP 8.5 in my XAMPP install Could potentially throw the instructions for that somewhere if we wanted to go through with this and not wait on XAMPP |
Member
Author
|
It's also possible that by the time this hits a release branch and it's a real concern for people not amenable to some (more) tinkering, an 8.3 version exists and it's a non-issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that Laravel 13 requires PHP 8.3 minimum; this is a breaking change.
Note that while I removed the (now unnecessary) security advisory overrides from
composer.json, I did not remove the santiziation middleware associated with one of them. That being said, upgrading Laravel should make it safe to do so.Marking this as draft pending testing and agreement that this is a sensible way to move forward.