Skip to content

feat(eth): web3signer external signer for remote Ethereum key custody - #3950

Draft
rickstaa wants to merge 3 commits into
masterfrom
rs/external-signer
Draft

feat(eth): web3signer external signer for remote Ethereum key custody#3950
rickstaa wants to merge 3 commits into
masterfrom
rs/external-signer

feat(eth): bound web3signer signing calls with a timeout

46d2ecc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 27, 2026 in 1s

33.30573% (+0.00559%) compared to e628b9c

View this Pull Request on Codecov

33.30573% (+0.00559%) compared to e628b9c

Details

Codecov Report

❌ Patch coverage is 54.13534% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.30573%. Comparing base (e628b9c) to head (46d2ecc).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
eth/web3signer.go 36.36364% 52 Missing and 4 partials ⚠️
cmd/livepeer/starter/starter.go 88.37209% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3950         +/-   ##
===================================================
+ Coverage   33.30014%   33.30573%   +0.00559%     
===================================================
  Files            171         172          +1     
  Lines          42174       42272         +98     
===================================================
+ Hits           14044       14079         +35     
- Misses         27077       27135         +58     
- Partials        1053        1058          +5     
Files with missing lines Coverage Δ
cmd/livepeer/starter/flags.go 87.50000% <100.00000%> (+0.18657%) ⬆️
cmd/livepeer/starter/starter.go 22.57426% <88.37209%> (+0.14559%) ⬆️
eth/web3signer.go 36.36364% <36.36364%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e628b9c...46d2ecc. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/flags.go 87.50000% <100.00000%> (+0.18657%) ⬆️
cmd/livepeer/starter/starter.go 22.57426% <88.37209%> (+0.14559%) ⬆️
eth/web3signer.go 36.36364% <36.36364%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.