Allow updating the pulse sink reaper at runtime#1294
Merged
Conversation
Follow-up to #1289, addressing the review comment about updating the reaper config after service start. The monitor previously snapshotted pulse_sink_reap_grace_sec once in NewMonitor and only started the reaper goroutine if reaping was enabled at boot, so the grace could not be tuned and reaping could not be enabled or disabled without a restart. The reaper goroutine now always runs and re-reads the grace (an atomic.Duration on the monitor) every tick. Monitor.SetPulseSinkReapGraceSec lets embedders apply an updated value on a live service: positive values take effect on the next tick, non-positive disables reaping. While disabled, the loop skips pactl entirely and clears its orphan tracking, so re-enabling starts a fresh grace period instead of instantly reaping sinks tracked before the flip. Config semantics are unchanged (0 = default, negative = disable).
boks1971
approved these changes
Jul 13, 2026
biglittlebigben
approved these changes
Jul 13, 2026
Contributor
|
AV-sync stats summary: view in run #29249565002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1289, addressing the review comment about updating the reaper config after service start. The monitor previously snapshotted pulse_sink_reap_grace_sec once in NewMonitor and only started the reaper goroutine if reaping was enabled at boot, so the grace could not be tuned and reaping could not be enabled or disabled without a restart.
The reaper goroutine now always runs and re-reads the grace (an atomic.Duration on the monitor) every tick. Monitor.SetPulseSinkReapGraceSec lets embedders apply an updated value on a live service: positive values take effect on the next tick, non-positive disables reaping. While disabled, the loop skips pactl entirely and clears its orphan tracking, so re-enabling starts a fresh grace period instead of instantly reaping sinks tracked before the flip. Config semantics are unchanged (0 = default, negative = disable).