Enable testing support on Windows#3542
Merged
igaw merged 5 commits intoJul 3, 2026
Merged
Conversation
brgoing
force-pushed
the
bgoing/upstream-windows-testing-support
branch
from
13eaba1 to
7bdc01b
Compare
Adds an is_windows check to nvme tests, and skips tests on Windows for commands that aren't supported by the Windows driver. Signed-off-by: Broc Going <bgoing@micron.com>
Updates the meson configuration for tests to add the project build root and other required directories to the path in a project-agnostic way. Also ensures that the environment variable needed for running tests within the Windows msys2 environment get copied into the test environment. Signed-off-by: Broc Going <bgoing@micron.com>
On Windows, reading some of the features used in the get features test is not supported. Updates the get features test to work on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
The \u202f code does not work for matching the separator used on Windows. Previously the test was ignoring the actual thousands_sep value for the locale and assuming it would match \u202f. Update the test to use the thousands_sep value from the locale to build the comparison string. Signed-off-by: Broc Going <bgoing@micron.com>
Updates build configuration to allow testing to be enabled on Windows and to exclude Linux-specific test on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
Collaborator
|
Nice! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables testing support on Windows and updates tests to run on Windows.