Make persistent discovery controller configurable for the subsystem#3536
Open
hreinecke wants to merge 1 commit into
Open
Make persistent discovery controller configurable for the subsystem#3536hreinecke wants to merge 1 commit into
hreinecke wants to merge 1 commit into
Conversation
Collaborator
Author
|
This is a somewhat competing implementation to #3472; I'm not trying to change the default, but rather control the creation of a PDC on a per-subsystem basis. |
Some subsystems / vendors might choose to enable or disable persistent discovery controllers for particular subsystems, independent on the global option to enable PDCs. This patch adds a new subsystem configuration option 'persistent_discovery_controller', which controls whether a PDC should be created for this subsystem. The value defaults to the host PDC setting if not specified in the configuration file. Signed-off-by: Hannes Reinecke <hare@suse.de>
igaw
reviewed
Jul 3, 2026
| disconnect = true; | ||
| else | ||
| disconnect = false; | ||
| disconnect = libnvme_subsystem_get_pdc_enabled(s); |
Collaborator
There was a problem hiding this comment.
yeah, this makes a lot of sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some subsystems / vendors might choose to enable or disable persistent discovery controllers for particular subsystems, independent on the global option to enable PDCs.
This patch adds a new subsystem configuration option 'persistent_discovery_controller', which controls whether a PDC should be created for this subsystem. The value defaults to the host PDC setting if not specified in the configuration file.