Repository navigation
docs(ui): clarify JsVar proposals and hidden Go fields - #534
Merged
Merged
Conversation
A partial JsVarStore whose Go type has unexported or json:"-" fields let a WebSocket peer learn whether that hidden state was zero. jq skips the ClientCheck callback for Go-equal values, so a forged `path=null` was a silent no-op when hidden fields were zero but reached ClientCheck (alert on deny, publish on allow) when they were not, with identical browser JSON. Record at store creation whether a plain type has such fields, and for those stores check and publish unchanged proposals like changed ones. The check sees the same next value either way, so the outcome depends only on its decision. This adds no work beyond what a changing proposal already costs.
linkdata
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullproposals for structs zero all Go fields, including unexported andjson:"-"fields.ClientCheckmust validate the complete tentative value, including parent/root changes and fields omitted from JSON.Scope
Documentation only: the JsVar guide and Go API comments. Runtime code and tests match
main.Verification
go docforJsVarCheckandJsVarStore.