Repository navigation
Support native multiple-selection selects - #530
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ui.MultiSelectandRequestWriter.MultiSelect, backed bynamed.MultiSelectHandlerornamed.NewBoolArray(true). Browser events send every selected option, and Go updates reconcile the complete selection, including clearing all options. Rejected, unchanged, and malformed input restore the authoritative selection. Existing single-selection behavior is preserved.Reuses the existing container lifecycle and input/value messages with JSON arrays; no new dependencies or protocol commands. Tests cover browser events, initial rendering, option updates, rejected changes, empty selections, and dirty targets.
Closes #518.
Validation:
JAWS_REQUIRE_NODE=1 go test ./...JAWS_REQUIRE_NODE=1 go test -race ./...go generate ./...,go build ./...,go vet ./...staticcheck ./...,golangci-lint run,gosec -quiet ./...