Repository navigation
Remove unused form auto-submit hook - #529
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-jawsonchangesubmitbrowser hook.changeevent and exact Input frame; Range still usesinput.Rationale
Public GitHub code search found the attribute only in JaWS's listener and test. A search of fresh default-branch clones of the six public
linkdatarepositories found through their JaWSgo.moddependency (edm-loadgen,jawsauth,jawsdemo,jawstree,rinse, andxyzzy) found no use. Private downstream use cannot be determined from this search.The hook has no Go emitter or documentation. It also calls
form.submit(), which skips validation and submit handlers, and throws when the marked element has no owning form. Removing it takes the unused-hook option described in the issue. Number'sdata-jawsnumberchange routing remains intact.Checks
git diff --checkpassed.jawsonchangesubmitreferences.Closes #506