Skip to content

Report missing JsVar parents consistently - #458

Merged
linkdata merged 1 commit into
mainfrom
fix/jsvar-missing-parent
Sep 29, 2026
Merged

linkdata merged 1 commit into
mainfrom
fix/jsvar-missing-parent

Conversation

@linkdata

Copy link
Copy Markdown
Owner

Summary

  • Make a missing intermediate JsVar parent raise the same JaWS path error as a missing direct parent.
  • Document that dotted store bindings need their parent objects on window before jaws.js runs; startup still fails fast if the precondition is unmet.
  • Add a browser-client regression test for shallow and deep missing parents plus a valid path.

Verification

  • Regression test failed before the fix with a raw TypeError for a.b.c and passes after the fix.
  • JAWS_REQUIRE_NODE=1 go test -race ./...
  • JAWS_REQUIRE_NODE=1 go test ./...
  • go vet ./...
  • node --check lib/assets/jaws.js

Fixes #431

@linkdata
linkdata merged commit 8df1466 into main Sep 29, 2026
7 checks passed
@linkdata
linkdata deleted the fix/jsvar-missing-parent branch September 29, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assets: missing JsVar parent object stops jaws.js before WebSocket connects

1 participant