Add AssetMapper support

[tito10047]

Q	A
Branch?	2.x
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	#1608
License	MIT
Doc

This pr introduce asset_mapper integration. its created assetMaper locator that is injected to filesystem loader.

when@dev:
    liip_imagine:
        loaders:
            asset_mapper:
                asset_mapper:
            chain:
                chain:
                    loaders: [ asset_mapper, default ]
        data_loader: chain

[tito10047]

Merry Christmas :)

[dbu]

thanks a lot for looking into this!

seems like a good addition, and seems to work with little additional code 👍

i have a few questions and suggestions

[dbu]

i think you need to add the asset mapper to the dev dependencies in composer.json

not sure what is going on with the legacy builds, those failures are probably unrelated to your changes.

[dbu]

not sure what is going on with the legacy builds, those failures are probably unrelated to your changes.

actually, this is about using language features that are only available in php 8. but i think its time to ditch that ultra legacy. i will adjust the minimum requirement to php 8.

[dbu]

please rebase on the 2.x branch to build with only php 8, that should fix the build errors

[coveralls]

coverage: 79.645% (-0.6%) from 80.201%
when pulling ae06e8f on tito10047:asset-mapper
into dec6314 on liip:2.x.

[dbu]

thanks, i think we are almost there.

can you please look at the cs fixer report? and i commented a few last things.

[tito10047]

I dont know where to fix Coverrals. there must be added asset mapper package when symhony is higger than 6.4

[dbu]

thanks a lot for this contribution!

[tito10047]

thanks a lot for this contribution!

Can I help with version 3 ? is there something to do?

[dbu]

released your changes as https://github.com/liip/LiipImagineBundle/releases/tag/2.17.0

for version 3: difficult question. we discussed the vision of radically refactoring the bundle to make the naming clearer and be able to better cover the various needs (e.g. on-the-fly image transform vs upfront transform). and get rid of most of the loader stuff in favor of flysystem (which did not exist when LiipImagineBundle was created, but now that it does there is no point in us maintaining e.g. S3 support in this bundle)
that was 1.5 years ago, and after initial brainstorming we did not find time to progress. as we want to really rethink the bundle, we need a focussed effort first to set the new basis... if it does sound interesting to you, a review of #1590 would be appreciated.

[dmaicher]

we should mark this ->abstract() (it would also fix #1648)