LCORE-3051: In the rag-content images, only install what is needed - #246
LCORE-3051: In the rag-content images, only install what is needed#246syedriko wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughContainer builds reduce builder inputs and runtime artifacts while installing Ruby dependencies for AsciiDoc processing. New fixtures and integration tests validate conversion, and the Konflux pipeline adds conversion verification as its first of seven phases. ChangesAsciiDoc support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant KonfluxPipeline
participant RagContentContainer
participant AsciidoctorConverter
participant ReferenceFixture
KonfluxPipeline->>RagContentContainer: run AsciiDoc conversion
RagContentContainer->>AsciidoctorConverter: convert fixture.adoc
AsciidoctorConverter->>KonfluxPipeline: produce converted.md
KonfluxPipeline->>ReferenceFixture: compare converted.md with fixture.md
KonfluxPipeline->>KonfluxPipeline: continue remaining integration phases
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
39009df to
26930b1
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/asciidoc/test_integration.py (1)
34-37: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUpdate the skip reason message.
The skip reason says
run 'bundle install' first, but the container now installs asciidoctor viagem install asciidoctorinstead of Bundler. Update the message to reflect the current installation method.📝 Proposed fix
requires_asciidoctor = pytest.mark.skipif( not shutil.which("ruby") or not shutil.which("asciidoctor"), - reason="ruby and/or asciidoctor not installed (run 'bundle install' first)", + reason="ruby and/or asciidoctor not installed (run 'gem install asciidoctor')", )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/asciidoc/test_integration.py` around lines 34 - 37, Update the reason string on the requires_asciidoctor pytest skip marker to instruct users to run “gem install asciidoctor” instead of “bundle install”, while preserving the existing dependency-missing conditions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/asciidoc/test_integration.py`:
- Around line 34-37: Update the reason string on the requires_asciidoctor pytest
skip marker to instruct users to run “gem install asciidoctor” instead of
“bundle install”, while preserving the existing dependency-missing conditions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 61387e11-8e85-4ba9-881d-b228bf7a4af1
📒 Files selected for processing (6)
ContainerfileContainerfile-cudatests/asciidoc/fixture.adoctests/asciidoc/fixture.mdtests/asciidoc/test_integration.pytests/integration-konflux/pipeline-konflux.sh
1d37621 to
05be5a2
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Containerfile-cuda`:
- Around line 80-82: Update the Bundler setup around the Gemfile copy and bundle
install so it uses the prefetched Cachi2 dependency source or an approved
internal mirror instead of accessing rubygems.org. Configure the required
offline/hermetic Bundler source before invoking bundle install, while preserving
the existing dependency installation flow.
In `@tests/integration-konflux/pipeline-konflux.sh`:
- Around line 59-68: Replace the world-writable permissions around the Asciidoc
conversion with a private temporary output directory and configure the podman
invocation to write as the host user, using :U, --userns keep-id, or an
equivalent mechanism. Remove both chmod operations while preserving the /output
mount and converted.md generation; apply the same ownership pattern to the other
temporary-directory setup blocks below.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ed13fa59-dd34-48b3-8cd1-38be418e7517
📒 Files selected for processing (6)
ContainerfileContainerfile-cudatests/asciidoc/fixture.adoctests/asciidoc/fixture.mdtests/asciidoc/test_integration.pytests/integration-konflux/pipeline-konflux.sh
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/asciidoc/fixture.adoc
- tests/asciidoc/test_integration.py
- Containerfile
e8c0939 to
b805058
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/integration-tests/pipeline/rag-content-0-7-integration-test.yaml:
- Line 295: Update the GPU test path’s package installation command near the
equivalent TEST_CMD invocation to include diffutils, matching the CPU path’s
dependencies. Preserve the existing installation packages and command execution.
In `@tests/asciidoc/fixture.md`:
- Around line 28-31: Update the AsciiDoc-to-Markdown conversion logic for
admonition blocks such as [NOTE] ... ---- so they render as blockquotes with an
emphasized label instead of raw delimiter lines that Markdown parses as setext
headings. Then revise the tests/asciidoc/fixture.md fixture’s expected output to
match the corrected admonition format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0029b24f-0ec8-4672-bfeb-826c6cc73fc9
📒 Files selected for processing (7)
.tekton/integration-tests/pipeline/rag-content-0-7-integration-test.yamlContainerfileContainerfile-cudatests/asciidoc/fixture.adoctests/asciidoc/fixture.mdtests/asciidoc/test_integration.pytests/integration-konflux/pipeline-konflux.sh
🚧 Files skipped from review as they are similar to previous changes (4)
- tests/asciidoc/fixture.adoc
- tests/asciidoc/test_integration.py
- Containerfile-cuda
- Containerfile
b805058 to
bea1e15
Compare
1 participant
Description
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit
config.yamloptions (proxy_url,timeout).