-
Notifications
You must be signed in to change notification settings - Fork 97
RHIDP-15891: add /v1/skills endpoint #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yangcao77
wants to merge
10
commits into
lightspeed-core:main
Choose a base branch
from
yangcao77:list-skills-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+766
−5
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
056bcf6
add /v1/skills endpoint
yangcao77 d5cabc5
update openapi doc
yangcao77 450a1d3
fix formatting
yangcao77 aae3d69
fix coderabbit review comment
yangcao77 3f5a80d
address review comments
yangcao77 2ca195b
Merge branch 'main' of github.com:lightspeed-core/lightspeed-stack in…
yangcao77 95bccef
fix coderabbit review
yangcao77 e78fcea
update docs
yangcao77 f160d44
resolve conflicts
yangcao77 fcff6a5
address review addess
yangcao77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| """Handler for REST API call to list loaded agent skills.""" | ||
|
|
||
| from typing import Annotated, Any | ||
|
|
||
| from fastapi import APIRouter, Request | ||
| from fastapi.concurrency import run_in_threadpool | ||
| from fastapi.params import Depends | ||
|
|
||
| from authentication import get_auth_dependency | ||
| from authentication.interface import AuthTuple | ||
| from authorization.middleware import authorize | ||
| from configuration import configuration | ||
| from log import get_logger | ||
| from models.api.responses.constants import UNAUTHORIZED_OPENAPI_EXAMPLES | ||
| from models.api.responses.error import ( | ||
| ForbiddenResponse, | ||
| InternalServerErrorResponse, | ||
| UnauthorizedResponse, | ||
| ) | ||
| from models.api.responses.successful import SkillsResponse | ||
| from models.config import Action | ||
| from utils.endpoints import check_configuration_loaded | ||
| from utils.pydantic_ai_helpers import get_skills_metadata | ||
|
|
||
| logger = get_logger(__name__) | ||
| router = APIRouter(tags=["skills"]) | ||
|
|
||
|
|
||
| skills_responses: dict[int | str, dict[str, Any]] = { | ||
| 200: SkillsResponse.openapi_response(), | ||
| 401: UnauthorizedResponse.openapi_response(examples=UNAUTHORIZED_OPENAPI_EXAMPLES), | ||
| 403: ForbiddenResponse.openapi_response(examples=["endpoint"]), | ||
| 500: InternalServerErrorResponse.openapi_response(examples=["configuration"]), | ||
| } | ||
|
|
||
|
|
||
| @router.get("/skills", responses=skills_responses) | ||
| @authorize(Action.GET_SKILLS) | ||
| async def skills_endpoint_handler( | ||
| request: Request, | ||
| auth: Annotated[AuthTuple, Depends(get_auth_dependency())], | ||
| ) -> SkillsResponse: | ||
| """Handle requests to the /skills endpoint. | ||
|
|
||
| Process GET requests to the /skills endpoint, returning a list of loaded | ||
| agent skills with their metadata (name, description). | ||
|
|
||
| ### Parameters: | ||
| - request: The incoming HTTP request (used by middleware). | ||
| - auth: Authentication tuple from the auth dependency (used by middleware). | ||
|
|
||
| ### Raises: | ||
| - HTTPException: with status 401 for unauthorized access. | ||
| - HTTPException: with status 403 if permission is denied. | ||
| - HTTPException: with status 500 and a detail object containing `response` | ||
| and `cause` when service configuration is wrong or incomplete. | ||
|
|
||
| ### Returns: | ||
| - SkillsResponse: An object containing the list of loaded skills. | ||
| """ | ||
| _ = auth | ||
| _ = request | ||
|
|
||
| check_configuration_loaded(configuration) | ||
|
|
||
| skills_metadata = await run_in_threadpool( | ||
| get_skills_metadata, configuration.configuration.skills | ||
| ) | ||
| return SkillsResponse(skills=skills_metadata) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.