Saturation and bleed effects - #18
Merged
Merged
Conversation
Nschanche
reviewed
Aug 25, 2026
Contributor
Author
|
I'm trying to figure out why the action failed, it looks like poetry is failing to install |
Contributor
Author
|
I pushed updates for:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements saturation and bleed effect on CCD type detectors that conserve charge and bleed along the columns, such as those in Kepler and TESS.
What's implemented:
saturate_and_bleed()fucntion inutils.pywhich inputsprf_fluxand detectorwell_depthand returns the version with saturation and bleed.PRF.evaluate()to turn on the saturation effect, these are a boolean variable and a list of the expected flux of the targets which is needed to apply the effect.Here are some examples to show that the scale of the bleed columns are consistent between model (first example) and data (second example).
Kepler
TESS