Aperture module and SNR-optimal aperture - #17
Open
jorgemarpa wants to merge 22 commits into
Open
jorgemarpa wants to merge 22 commits into
jorgemarpa wants to merge 22 commits into
Conversation
Created an aperture class
To show new aperture class
Adjusted code to make get_aperture function
Updated poetry lock (lightkurve#14)
…like-snr-aperture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds upon previous PR #15 to implement an aperture module that enables aperture mask creation from the PRF model. It includes the following:
aperturemodule with methods to compute metrics and apertures. It inputs a PRF model, or a list of PRF models for several sources in the scene, and the source magnitudes1. Simple: based on a flux completeness value. This is the simplest mask and only needs the target PRF.
2. SNR-optimal: simirlarly to SPOC aperture, it optimizes the cumulative SNR as a funciton of pixels added to the aperture (sorted by highest SNR pixel). This needs the PRF ealuation for all sources in the scene and their expeced flux, in order to compute the noise in the aperture. It also enables including read and quantization noise for a more realistic noise estimation.
3. Balanced: creates an aperture that satisfies crowding and flux fraction thresholds defined by the user.
PRFclass has aget_aperture()method that uses theaperturemodule to compute apertures for the prf object.lkprf_aperture_example.ipynbnotebook tutorial showcasing the newaperturemodule.Closes / Supersedes #15