Repository navigation
feat(app-ui): render Button and IconButton as links with href - #891
Merged
Merged
Conversation
With `href`, Button and IconButton render an <a> through LinkProvider (linkProps, disabled -> aria-disabled); without it they stay a <button>. Props are a union on href: loading/type are button-only. LinkButton is kept as a deprecated alias. Absolute http(s) and protocol-relative URLs now open in a new tab (target=_blank, rel=noopener noreferrer) for every app-ui link unless `target` is passed; NavLink's external arrow follows the same rule. `external` is deprecated but still honored (`false` opts out). IconButton and surface styles treat [aria-disabled='true'] like :disabled and drop text-decoration, so the link renders identically. Link stories move into the Button/IconButton stories; the LinkProvider demo router is extracted to .storybook/components/DemoRouter.
- share strict button/link prop halves via ActionElement; AsButton/AsLink props now include own props, drop casts and OwnProps exports - inline IconButtonContent, move joinAriaLabel to utils - inherit deprecated `external` from AnchorProps, drop dead plumbing - merge identical outline/ghost hover rules, trim LinkProvider JSDoc - tests: reuse RouterLink, drop Anchor-covered cases, void type checks
Preview stand statusStand was demolished |
cakeinpanic
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button and IconButton accept
hrefand render an<a>through LinkProvider; without it they stay a<button>.href:loading/typeare button-only;disabledon a link →aria-disabled, styled like:disabled.LinkButtonkept as a deprecated alias of<Button href>.http(s)/ protocol-relative URLs now open in a new tab (target=_blank,rel=noopener noreferrer) for every app-ui link unlesstargetis passed; NavLink's external arrow follows the same rule.externalis deprecated but still honored (external={false}opts out).