Repository navigation
Conversation
exromany
changed the title
Stack, Grid and GridItem breakpoint keys now also respond to a `lido-app-ui-page` container, set on SidebarInset. With the sidebar shown, content sees the viewport minus the sidebar, so layouts no longer gain columns when the sidebar collapses at 1280px. Outside a page container the media rules still apply unchanged. Exports pageContainerName for apps without SidebarInset.
exromany
force-pushed
the
feat/app-ui-breakpoints
branch
from
October 30, 2026 12:39
391c8ec to
95faa9f
Compare
exromany
force-pushed
the
feat/app-ui-page-column
branch
from
October 30, 2026 12:39
3e7d95b to
b721a73
Compare
Preview stand statusStand was demolished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack, Grid and GridItem breakpoint keys now measure the page column instead of the viewport when they sit inside
SidebarInset. Layouts no longer gain columns when the sidebar collapses.SidebarInset, behaviour is unchanged. The mixin emits the existing@mediarules plus@container lido-app-ui-pagerules after them. The column is never wider than the viewport, so the narrower result wins.lg/ml). ChecklgDown/mlDownvalues in those apps.Hiddenfollows the column too.belowhides when the column is narrower.abovehides on the viewport but shows again when the column is narrower. New media-onlysidebarkey (1280, the drawer switch) for shell chrome. The header logo in the recipes now usesHidden above='sidebar', which also fixes the missing logo at 1024–1279. NewHiddenBreakpointtype export.Modal,Logo, the sidebar and page gutters stay viewport-based.pageContainerNameexport: apps withoutSidebarInsetcan make their main column the page container.smpx in the Grid and Stack story docs.