Repository navigation
feat(process): support value equality for backoff policies - #185
Merged
Merged
Conversation
Allow lifecycle consumers to compare backoff settings explicitly when classifying process changes, without depending on Debug formatting.
|
Review changes with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
PartialEqandEqforBackoffso core-manager can compare process options by value instead of comparing the Debug output of all instance options. No backoff timing behavior changes.Required by libnyanpasu/nyanpasu-runtime#414 and its controller-policy classification fix.
Validation: downstream core-manager library (107 tests), channel integration (2 tests), service-runtime (87 tests), and application checks exercised the change. The classifier regression verifies that changing backoff still counts as a process change while controller preference alone does not.