Repository navigation
Add durable shared approval storage and atomic decisions - #523
Open
leprachuan wants to merge 2 commits into
Open
leprachuan wants to merge 2 commits into
leprachuan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple UIs must share one durable approval decision without duplicate execution. This adds isolated SQLite request storage bound to owner/responsibility/action fingerprint, idempotent creation, atomic first decisions, expiry/cancellation, owner-filtered event cursors, and single-use reservations that survive restart. Raw action arguments and secrets are not persisted.
Validation: 47 focused tests passed on dev 192.168.1.100 (23 policy + 24 approval), including concurrent decisions across three store connections, single-use claim races, restart, owner isolation, changed arguments, cancellation, expiry and private database permissions.
Stacked on policy foundation PR #521. Tracks Stage 2 issue #522 and umbrella #519; Stage 2 remains incomplete. No API/service/runtime behavior changes. Public API authorization, live event delivery, sanitized previews, always-allow JSON rule transactions, execution revalidation and all runtime boundaries remain disabled/unwired and are documented as the next slices. A reservation does not guarantee an external action occurred; uncertain outcomes require reconciliation.