Skip to content

Add advice to mark-set command for multicursor selection #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Plipus wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add advice to mark-set command for multicursor selection #2263

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
572587e
Add advice to mark-set command for multicursor selection
Plipus Jul 5, 2026
a72ca5d
Remove unwanted advice, use check on cursor type
Plipus Jul 10, 2026
208d344
Add documentation string
Plipus Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/mark.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
(define-key *global-keymap* "C-x C-x" 'exchange-point-mark)
(define-key *global-keymap* "C-x h" 'mark-set-whole-buffer)

(define-command mark-set (p) (:universal-nil)
(define-command (mark-set (:advice-classes editable-advice)) (p) (:universal-nil)

@theangelperalta theangelperalta Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant: mark-set already has an execute :around doing process-each-cursors at line 38-41, and editable-advice adds the same wrapper — so this nests two process-each-cursors passes. In a headless test it didn't change the multicursor result (still crashes in the per-cursor (message "Mark set") below).

"Sets a mark at the current cursor position."
(if p
(move-point (current-point) (pop-buffer-point))
Expand Down
Loading